Fix performance calculation after contest #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit efebae1. Nope, this is not enough because predictions are off now for the old contest where we were fully accurate before.
We were accurate on this contest which predates fake ratings, but are no longer after this adjustment.
This reverts commit f21751d. I'm silly
This means old contests continue to have perfect prediction, and the adjustment is applied to new contests based on the ID.
|
Hi, I've moved the rating adjustment from the predictor to the contest cache. This way we can conditionally apply the adjustment to new contests (after fake ratings) while leaving alone the near-perfect performance values for old contests. I will merge this after testing on CF. Unfortunately I can't do that right now since the API has been put behind the Cloudflare human check (again) (lol). |
|
Ok things seem to be alright, the result for this example is as expected.
|
|
Thanks for doing this, even if I ended up shifting the logic elsewhere :ghosthug: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #52
Screenshot taken from https://codeforces.com/contest/1919/standings/page/17 and https://codeforces.com/contest/1919/ratings/page/33