Create gesture events for mce and enable CIFS module #3
Conversation
| @@ -3809,11 +3857,14 @@ static void synaptics_rmi4_set_params(struct synaptics_rmi4_data *rmi4_data) | |||
| set_bit(KEY_HOMEPAGE, rmi4_data->input_dev->keybit); | |||
| set_bit(KEY_F3, rmi4_data->input_dev->keybit); | |||
| set_bit(KEY_DOUBLE_TAP, rmi4_data->input_dev->keybit); | |||
There was a problem hiding this comment.
Should KEY_DOUBLE_TAP be disabled too?
There was a problem hiding this comment.
I thought that mce could also handle a power key event generated by the touch screen. That and the fact that it was not disabled in the onyx kernel let me decide to leave it enabled.
There was a problem hiding this comment.
MCE can/does handle power key as double tap, but I was thinking more in the line of: "After the changes elsewhere, is the kernel driver ever going to emit power key events anymore?" If not (i.e. KEY_DOUBLE_TAP aka KEY_POWER is always converted to MSC_GESTURE event), then it would be incorrect to claim that the input device can emit power key events.
| set_bit(KEY_GESTURE_LTR, rmi4_data->input_dev->keybit); | ||
| set_bit(KEY_GESTURE_GTR, rmi4_data->input_dev->keybit); | ||
| set_bit(EV_MSC, rmi4_data->input_dev->evbit); | ||
| rmi4_data->input_dev->mscbit[0] = BIT_MASK(MSC_GESTURE); |
There was a problem hiding this comment.
This looks a bit odd to me. Was expecting to see series of calls like
set_bit(MSC_GESTURE_xxx, rmi4_data->input_dev->mscbit);
There was a problem hiding this comment.
Indeed that would probably work. It compiles but it will take me some time to verify it's working.
There was a problem hiding this comment.
Sorry, I think I was confused for a while.
With here is only one gesture "event" (that can have multiple values). So unless there are other MSC_xxx events, then your original code was correct.
If there are other than MSC_GESTURE events, then using:
set_bit(MSC_GESTURE, rmi4_data->input_dev->mscbit);
would not clear other already set bits.
native vibrator support
No description provided.