Remove oldmodel macro use #1735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zuckschwerdt
force-pushed
the
feat-removex
branch
2 times, most recently
from
4c66df3 to
30ff2ac
Compare
Mindavi
approved these changes
Jun 10, 2021
| @@ -1364,24 +1363,18 @@ r_device acurite_th = { | |||
| */ | |||
| static char *acurite_txr_output_fields[] = { | |||
| "model", | |||
| "subtype", // TODO: remove this | |||
| "message_type", // TODO: remove this | |||
There was a problem hiding this comment.
This one also has 'TODO: remove this'
| @@ -75,7 +75,7 @@ static int bt_rain_decode(r_device *decoder, bitbuffer_t *bitbuffer) | |||
| "battery", "Battery", DATA_STRING, battery ? "LOW" : "OK", | |||
| "transmit", "Transmit", DATA_STRING, button ? "MANUAL" : "AUTO", // TODO: delete this | |||
There was a problem hiding this comment.
Has a TODO: delete this, replaced by the 'button' value, I guess.
| @@ -91,7 +91,6 @@ static char *output_fields[] = { | |||
| "battery", | |||
| "transmit", // TODO: delete this | |||
There was a problem hiding this comment.
Can be removed as well if it's removed above.
|
Shouldn't this be the occasion to also make sure all the "battery" string fields are replaced by "battery_ok" int fields? |
|
Thanks. Yes, since there is no oldmodel switch anymore there's no reason to have old battery fields. I'll make a second PR for a clean history without merge commits. |
zuckschwerdt
force-pushed
the
feat-removex
branch
from
30ff2ac to
7ed4c4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the deprecated "oldmodel" workaround macro
_X().Regression checks pass, but if anyone can spare some time then please review.