fs20: Improve bitstream decoding, add some FHT support #1783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanBruens
force-pushed
the
fs20_fixes
branch
from
0e50c1b to
cedead1
Compare
|
I guess you could add Regarding |
The bitstream decoding is improved significantly: - The encoding is corrected to OOK_PULSE_PWM - Preamble scan is added, as sometimes a random leading bit is added, or the initial bit is dropped, both due to noise. - MIC/sanity check is added, i.e. parity is checked for each individual data byte, and the 'sum' byte is checked for a sane value. Also report the flags from the command byte, and the optional extension byte. The FHT protocol uses the same bitstream encoding as FS20, but can be detected by a different range for the sum byte. Add decode tables for cmd and flags.
StefanBruens
force-pushed
the
fs20_fixes
branch
from
cedead1 to
bf3c32d
Compare
zuckschwerdt
force-pushed
the
master
branch
2 times, most recently
from
8e31ece to
e42ad33
Compare
zuckschwerdt
force-pushed
the
master
branch
2 times, most recently
from
93031a1 to
ed794ec
Compare
|
@zuckschwerdt How about merging this but keeping it disabled ? |
|
I guess this dropped off waiting for feedback. I'll merge and correct the issues on top. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bitstream decoding is improved significantly:
the initial bit is dropped, both due to noise.
data byte, and the 'sum' byte is checked for a sane value.
Also report the flags from the command byte, and the optional extension
byte.
The FHT protocol uses the same bitstream encoding as FS20, but can be
detected by a different range for the sum byte. Add decode tables for
cmd and flags.