Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Altronics X7064 sensor and add support for Emax Weather Sensor #2300

Merged
merged 6 commits into from
Jan 22, 2023
Merged

Conversation

ProfBoc75
Copy link
Collaborator

I rewrite the original decoder for Altronics X7064 (Temp/Hum sensor) in order to take into account Weather Station, not properly decoded and where is missing Rain/Wind/UV/Lux information.

Now it decodes as EMAX sensor, and both Temp/Hum and 5-in-1 Sensor station are properly decoded.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@zuckschwerdt
Copy link
Collaborator

Can you also delete the old file devices/altronics_x7064.c and add that commit?
E.g. git remove src/devices/altronics_x7064.c ; git commit -m 'remove obsolete decoder'; git push

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@ProfBoc75
Copy link
Collaborator Author

Can you also delete the old file devices/altronics_x7064.c and add that commit? E.g. git remove src/devices/altronics_x7064.c ; git commit -m 'remove obsolete decoder'; git push

Done

};

r_device emax = {
.name = "EMAX Weather sensor",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be "EMAX EM3390W6 / Altronics X7064 weather sensor",
(people might otherwise wonder "where did the Altronics go?)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for your support.

Agree, the reason why I had left the older decoder file.
I found also several references for the same Weather Station.
For sure for Altronics : x7064 = simple Temp/Hum sensor and x7063 = 5-in-1 Rain/Wind/.... sensor :
https://www.altronics.com.au/p/x7063-touchscreen-wifi-wireless-home-weather-station/

For Emax , EM3390W6 is the brand reference into the Optex 990040 user guide in certification section.
I found also for Emax, W6, WEC-W6, 3390TX (W6) manuals.
Infactory version is also not clear, the Weather Station is called FWS-1200, but the reference is NX6396-944.

So could be "Emax W6 and rebrand Altronics x7063/4, Optex SM-040, Infactory FWS-1200, Newentor Q9 Weather sensor"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's a very good text to inform other people.

#include "decoder.h"

/**
Altronics X7064 / Emax temperature and humidity sensor.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be "Emax EM3390W6 / Altronics X7064 weather sensor."

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as previous message,
"Emax W6 and rebrand .... "


/* clang-format off */
data_t *data = data_make(
"model", "", DATA_STRING, "EMAX Temperature Humidity sensor",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can not change this now. Needs to stay "Altronics-X7064".
Change this later in new PR, e.g. "Altronics-X7064" -> "Emax-EM3390W6"
(see Model at https://triq.org/rtl_433/DATA_FORMAT.html#message-data)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I will update like that.

@zuckschwerdt
Copy link
Collaborator

This looks very good. Only slight changes needed.

Can you make sure all mentions of "EMAX" are written "Emax"?
And "EM3390W6" is the station number, right? Is there a sensor number also?

The full name would be "Fuzhou Emax Electronic W6 Professional Weather Station".
The decoder comment should mention "Fuzhou Emax W6 Weather Station (EM3390W6)" -- so we later know what "W6" and "3390" means (I thought W6 was a version number).

@ProfBoc75
Copy link
Collaborator Author

I made few corrections and rewording as requested.

Thx.

@touste
Copy link

touste commented Jan 8, 2023

Hi, I was trying to get data from my own weather station, and I came across this PR by searching for the hex preamble I got (I see this is just a couple day old, perfect timing!). I was able to get correct data (temp, wind speed and direction, humidity, rainfall) by using rtl_433 with this PR. The model I have is named "Orium Helios": https://www.aic-international.net/nos-produits/station-meteo-helios/
You may add this model reference if you wish.

@zuckschwerdt
Copy link
Collaborator

The model I have is named "Orium Helios": https://www.aic-international.net/nos-produits/station-meteo-helios/

Thanks for the report. Interesting to see the rebranding with all this ;)

@ProfBoc75
Copy link
Collaborator Author

ProfBoc75 commented Jan 8, 2023

The model I have is named "Orium Helios": https://www.aic-international.net/nos-produits/station-meteo-helios/

Thanks for the report. Interesting to see the rebranding with all this ;)

Yes, and for this Orium Helios, the internal weather display is little different than others, but the Rain Gauge/Wind looks exactly the same.

With Google Lens, I found other models.
With black & white lcd display without Wifi and with Color lcd display with Wifi connection.
For example Optex 990050 : https://www.groupe-normand.com/shop/990050-station-meteo-professionnelle-1366
Otio "La Surprenante" : https://v2.otio.com/produit/station-meteo-pro-la-surprenante-otio

Sounds like Emax is the OEM for a lot of brands ...

@ProfBoc75
Copy link
Collaborator Author

@zuckschwerdt : Hi, should I need to do something more or I just need to wait ? It's my first contribution and sounds like I need an approval in the workflow. Thx.

@zuckschwerdt
Copy link
Collaborator

Looks good, but the second "model" should be "Emax-W6", right?

@ProfBoc75
Copy link
Collaborator Author

Yes, correction made. Thx.

@zuckschwerdt zuckschwerdt mentioned this pull request Jan 18, 2023
@zuckschwerdt
Copy link
Collaborator

@ProfBoc75 there are two more rebrands in #2326 which you might like to add to the list?

@ProfBoc75
Copy link
Collaborator Author

@ProfBoc75 there are two more rebrands in #2326 which you might like to add to the list?
Hi @zuckschwerdt
Definitely, this china model is popular and all countries resell it in one or more brands 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants