-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Altronics X7064 sensor and add support for Emax Weather Sensor #2300
Conversation
Can you also delete the old file |
Done |
src/devices/emax.c
Outdated
}; | ||
|
||
r_device emax = { | ||
.name = "EMAX Weather sensor", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be "EMAX EM3390W6 / Altronics X7064 weather sensor",
(people might otherwise wonder "where did the Altronics go?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for your support.
Agree, the reason why I had left the older decoder file.
I found also several references for the same Weather Station.
For sure for Altronics : x7064 = simple Temp/Hum sensor and x7063 = 5-in-1 Rain/Wind/.... sensor :
https://www.altronics.com.au/p/x7063-touchscreen-wifi-wireless-home-weather-station/
For Emax , EM3390W6 is the brand reference into the Optex 990040 user guide in certification section.
I found also for Emax, W6, WEC-W6, 3390TX (W6) manuals.
Infactory version is also not clear, the Weather Station is called FWS-1200, but the reference is NX6396-944.
So could be "Emax W6 and rebrand Altronics x7063/4, Optex SM-040, Infactory FWS-1200, Newentor Q9 Weather sensor"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's a very good text to inform other people.
src/devices/emax.c
Outdated
#include "decoder.h" | ||
|
||
/** | ||
Altronics X7064 / Emax temperature and humidity sensor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be "Emax EM3390W6 / Altronics X7064 weather sensor."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as previous message,
"Emax W6 and rebrand .... "
src/devices/emax.c
Outdated
|
||
/* clang-format off */ | ||
data_t *data = data_make( | ||
"model", "", DATA_STRING, "EMAX Temperature Humidity sensor", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can not change this now. Needs to stay "Altronics-X7064".
Change this later in new PR, e.g. "Altronics-X7064" -> "Emax-EM3390W6"
(see Model at https://triq.org/rtl_433/DATA_FORMAT.html#message-data)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I will update like that.
This looks very good. Only slight changes needed. Can you make sure all mentions of "EMAX" are written "Emax"? The full name would be "Fuzhou Emax Electronic W6 Professional Weather Station". |
I made few corrections and rewording as requested. Thx. |
Hi, I was trying to get data from my own weather station, and I came across this PR by searching for the hex preamble I got (I see this is just a couple day old, perfect timing!). I was able to get correct data (temp, wind speed and direction, humidity, rainfall) by using rtl_433 with this PR. The model I have is named "Orium Helios": https://www.aic-international.net/nos-produits/station-meteo-helios/ |
Thanks for the report. Interesting to see the rebranding with all this ;) |
Yes, and for this Orium Helios, the internal weather display is little different than others, but the Rain Gauge/Wind looks exactly the same. With Google Lens, I found other models. Sounds like Emax is the OEM for a lot of brands ... |
@zuckschwerdt : Hi, should I need to do something more or I just need to wait ? It's my first contribution and sounds like I need an approval in the workflow. Thx. |
Looks good, but the second "model" should be "Emax-W6", right? |
Yes, correction made. Thx. |
@ProfBoc75 there are two more rebrands in #2326 which you might like to add to the list? |
|
I rewrite the original decoder for Altronics X7064 (Temp/Hum sensor) in order to take into account Weather Station, not properly decoded and where is missing Rain/Wind/UV/Lux information.
Now it decodes as EMAX sensor, and both Temp/Hum and 5-in-1 Sensor station are properly decoded.