Add support for Schou 72543 Rain sensor #2686

36jemini · 2023-10-23T21:16:51Z

Hi,

I have tried to my best ability to write up a decoder for my Schou rain sensor (model: 72543).
The code is not 100% done, but it is at a stage where I would like to request some help.

I have added a pull request with test samples and a longer device description to the rtl_433_tests project,
which has not yet been merged in, so please find it here until then: https://github.com/36jemini/rtl_433_tests/tree/master/tests/Schou

I would like some guidance on,

In which file should I "register" the schou_72543_rain.c file?
Have I made the right approach to extract the data from the bitbuffer?

Comments, feedback and guidance will be highly appreciated.

…t embedded in code

36jemini · 2023-10-23T21:28:27Z

Also, should this be a "draft" Pull request? I'm still new to both git and github

zuckschwerdt · 2023-10-23T21:33:23Z

src/devices/schou_72543_rain.c

+    //Assuming option #1
+
+    // Full data is 3 rows, two are required for data validation
+    if(bitbuffer->num_rows < 2){


add space after keywords (if) and before braces.

zuckschwerdt · 2023-10-23T21:34:38Z

src/devices/schou_72543_rain.c

+    uint8_t micSum = b[7]; // Checksum as read
+    uint8_t calSum = 0;    // Checksum as calculated
+
+    for(i = 0; i<7; i++){


use int cal_sum = add_bytes(b, 7);

zuckschwerdt · 2023-10-23T21:37:04Z

* In which file should I "register" the _schou_72543_rain.c_ file?

include/rtl_433_devices.h then stage or commit and call ./maintainer_update.py. Compile and call ./maintainer_update.py again.

2) schou_72543_rain added to include/rtl_433_devices.h

Conflicts: include/rtl_433_devices.h Solution: rearrange schou_72543_rain after tmps_nissan

zuckschwerdt · 2023-10-26T20:27:16Z

src/devices/schou_72543_rain.c

@@ -70,7 +69,7 @@ static int schou_72543_rain_decode(r_device *decoder, bitbuffer_t *bitbuffer)
    //Assuming option #1

    // Full data is 3 rows, two are required for data validation
-    if(bitbuffer->num_rows < 2){
+    if (bitbuffer->num_rows < 2){


and a space near the end :)

src/devices/schou_72543_rain.c

zuckschwerdt · 2023-10-26T20:29:42Z

src/devices/schou_72543_rain.c

    rain_mm         =  ((b[4] << 8 ) & b[3]) / 10.0f;
-	temp_F          = (((b[6] << 8 ) & b[5]) / 10.0f) - 90;
+    temp_F          = (((b[6] << 8 ) & b[5]) / 10.0f) - 90;


this would be better written as (((b[6] << 8 ) | b[5]) - 900) * 0.1f;
also above, and note to use | not &

zuckschwerdt · 2023-10-26T20:30:24Z

src/devices/schou_72543_rain.c

    rain_mm         =  ((b[4] << 8 ) & b[3]) / 10.0f;
-	temp_F          = (((b[6] << 8 ) & b[5]) / 10.0f) - 90;
+    temp_F          = (((b[6] << 8 ) & b[5]) / 10.0f) - 90;

    /* clang-format off */
    data = data_make(
            "model",          "",             DATA_STRING, "Schou 72543 rain sensor",


model needs to be just "Schou-72543"

Thank you @zuckschwerdt for the comments. I seriously appreciate the support!
And I am sorry for the amount of commits. I still did not get the "squish" i think it is called of multiple- to one commit.

Happy to help. No need to squash. We'll do it on merge anyway.

…ully tested with the rtl_433_tests/tests/Schou/g*.cu8 files

* model name under r_device section and data_make section aligend to schou_72543

…r schou_72543_rain Updates - schou_72543 is now schou_72543_rain everywhere - temp_F has become temperature_F to simplify integration with Home Assistant - schou_72543_rain has device number 250 after merging changes from the merbanan/rtl_433 master branch

36jemini · 2023-11-07T21:59:51Z

Hi @zuckschwerdt,
I have made a few final touches to the code and would consider it done from my side.
I merged in the latest changes from the merbanan/rtl_433 master and have made a final commit.
Can you tell me if i need to do more to get this pull request closed/merged?
BR Jesper

jsiidorov · 2023-12-02T13:52:37Z

Hi Jesper & co,

This decoder looks similar to MTX rain gauge sold in Finland by Motonet (Product code: 86-01352) and MarQuant Wireless Rain Gauge (Product code: 014369) sold by JULA AB, Sweden.
A couple suggestions to decoder (End of this comment section):

Rain gauge range 0 .. 9999mm. (Display range)
Temperature range -40 .. 70C (-40 ..158F)

When running MTX device: rtl_433.exe -X n=MTX_RAIN,m=OOK_PWM,s=992,l=2696,r=2684,g=0,t=0,y=7088,bits=65,rows=3,repeats=2

Modulation: OOK_PWM
Short pulse: 992
Long pulse: 2696
Reset: 2684
gap: 0
Tolerance: 0
Sync: 7088
Rows: 3
Repeats: 2

Sample Data:

time : 2023-11-25 15:16:22
model : MTX_RAIN count : 2 num_rows : 3
rows :
len : 65 data : 3fcd0ef8ff0a041f0,
len : 65 data : 3fcd0ef8ff0a041f0,
len : 71 data : 3fcd0ef8ff0a041f02
codes : {65}3fcd0ef8ff0a041f0, {65}3fcd0ef8ff0a041f0, {71}3fcd0ef8ff0a041f02

Rain count is starting at power up as described from fff6, it is rotated to 0000 after ffff

Rain count is 0.108 mm / each gauge flip (instead of 0.1mm) according to my tests - can this be changed?
Now decoder is returning temperature in Fahrenheits and rain in mm. Could temperature to be reported in Celsius to be consistent? (Just change temperature_F to temperature_C and add - 32 / 1.8 to end.

Thanks

zuckschwerdt · 2023-12-02T17:41:56Z

Rain count is 0.108 mm / each gauge flip (instead of 0.1mm) according to my tests - can this be changed?

You can change that in the code and recompile. https://github.com/merbanan/rtl_433/blob/master/src/devices/schou_72543_rain.c#L80
We don't offer "calibration", maybe you can use a bridge, see https://github.com/merbanan/rtl_433/tree/master/examples

Now decoder is returning temperature in Fahrenheits and rain in mm. Could temperature to be reported in Celsius

Use -C si or convert si in a conf file.

36jemini added 2 commits October 23, 2023 22:55

Initial attempt at a decoder for Schou 72543 rain sensor. Help reques…

26b5b4f

…t embedded in code

Merge branch 'merbanan:master' into master

ff0e71f

zuckschwerdt reviewed Oct 23, 2023

View reviewed changes

36jemini added 4 commits October 26, 2023 20:17

Merge branch 'merbanan:master' into master

a25c50a

1) schou_72543_rain.c updated with recommendations from @zuckschwerdt.

83d582b

2) schou_72543_rain added to include/rtl_433_devices.h

Merge branch 'master' of github.com:36jemini/rtl_433_schou_raingauge

b23abf5

Conflicts: include/rtl_433_devices.h Solution: rearrange schou_72543_rain after tmps_nissan

after build

87e3b93

zuckschwerdt reviewed Oct 26, 2023

View reviewed changes

src/devices/schou_72543_rain.c Outdated Show resolved Hide resolved

run python script

4b9ca60

zuckschwerdt reviewed Oct 26, 2023

View reviewed changes

36jemini added 8 commits October 26, 2023 23:03

Adding verbose debugging

c22137c

Working version of the schou_72543_rain decoder. It has been successf…

e2a75cd

…ully tested with the rtl_433_tests/tests/Schou/g*.cu8 files

Updating based on @zuckschwerdt's comments.

e6c34e2

adding the updates made by .maintainer_update.py

835c34b

* Code style check error corrected

2577b7e

* model name under r_device section and data_make section aligend to schou_72543

Update after maintainer_update.py

e276c4b

Re-ordered data output in more sensible way with important data first.

c7947ab

zuckschwerdt added 4 commits November 8, 2023 20:12

Cleanup

06aebf3

Cleanup code

1c7534c

Change verbose name

022ed4b

Cleanup names

3065cdd

zuckschwerdt merged commit bd452d9 into merbanan:master Nov 8, 2023
5 checks passed

zuckschwerdt added a commit that referenced this pull request Dec 3, 2023

Add Motonet MTX, MarQuant Rain note to Schou-72543 (#2686)

d0425f9

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for Schou 72543 Rain sensor #2686

Add support for Schou 72543 Rain sensor #2686

36jemini commented Oct 23, 2023

36jemini commented Oct 23, 2023

zuckschwerdt Oct 23, 2023

zuckschwerdt Oct 23, 2023

zuckschwerdt commented Oct 23, 2023

zuckschwerdt Oct 26, 2023

zuckschwerdt Oct 26, 2023 •

edited

Loading

zuckschwerdt Oct 26, 2023

36jemini Oct 26, 2023

zuckschwerdt Oct 27, 2023

36jemini commented Nov 7, 2023

jsiidorov commented Dec 2, 2023

zuckschwerdt commented Dec 2, 2023

Add support for Schou 72543 Rain sensor #2686

Add support for Schou 72543 Rain sensor #2686

Conversation

36jemini commented Oct 23, 2023

36jemini commented Oct 23, 2023

zuckschwerdt Oct 23, 2023

Choose a reason for hiding this comment

zuckschwerdt Oct 23, 2023

Choose a reason for hiding this comment

zuckschwerdt commented Oct 23, 2023

zuckschwerdt Oct 26, 2023

Choose a reason for hiding this comment

zuckschwerdt Oct 26, 2023 • edited Loading

Choose a reason for hiding this comment

zuckschwerdt Oct 26, 2023

Choose a reason for hiding this comment

36jemini Oct 26, 2023

Choose a reason for hiding this comment

zuckschwerdt Oct 27, 2023

Choose a reason for hiding this comment

36jemini commented Nov 7, 2023

jsiidorov commented Dec 2, 2023

zuckschwerdt commented Dec 2, 2023

zuckschwerdt Oct 26, 2023 •

edited

Loading