-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Aldi Sempre 4-AH0423-4 temperature/rain sensor #2716
base: master
Are you sure you want to change the base?
Conversation
The changes you made look good for the Sempre type sensor, but will it continue to work with the original Auriol ones? As I understood, the Sempre sends more fields, so Auriol decoding will fail, isn't it? |
I checked with the available binary samples from #1837 and they all work was expected. Auriol samples:
Sempre sample:
Low battery sample:
|
Does the unit have a channel selector? What are the markings on that? |
If there is no channel we should just add the docs and change the check, e.g.
(if 0x2 is the fixed value) |
Reworked the check to evaluate the unknown, seemingly always |
|
||
if (b[3] != 0xf0) { | ||
if (b[3] != 0xf0 || (b[1] & 0x40) != 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will ignore the two bits. But don't we want to check that it's 0 or 3? I.e. 1 or 2 are invalid.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Depends, no idea if there are other brands of this rain meter out there that would use either ch1 or ch2 :/
You are getting a "channel" value of 3, right? With the Nexus logic of C+1 that would be CH4? So 0…2 as channel (as Nexus has) and then 3 for rain would be a good guess here? |
Yeps, I am getting channel 4 for my sempre rain meter, based on the nexus channel logic. The samples for Auriol result in channel 1 which could make sense that different brands use different channels for the rain meter. |
See the discussion in #1837