Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Grill Thermometer (RF-T0912) #2746

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

eshaz
Copy link
Contributor

@eshaz eshaz commented Dec 4, 2023

  • Adds support for the "Remote Grill Thermometer" (RF-T0912)
    • FCC ID: TXRFPT0912
    • Product Manual:
      image

@zuckschwerdt
Copy link
Collaborator

If the temp is 255-x then maybe the bits are inverted? I.e. use bitbuffer_invert(bitbuffer);

@eshaz
Copy link
Contributor Author

eshaz commented Dec 4, 2023

If the temp is 255-x then maybe the bits are inverted? I.e. use bitbuffer_invert(bitbuffer);

They probably are inverted. Since the output we care about is only one byte, I'm thinking it makes more sense to just do the one subtraction operation at the end, vs. invert the entire data.

@zuckschwerdt
Copy link
Collaborator

one subtraction operation at the end, vs. invert the entire data.

Maybe do an xor, it's easier to glance what's going on then.

@zuckschwerdt
Copy link
Collaborator

Looks good already. Please split the multi-assign lines (40, 68).

If possible abort on all 1's and all 0's in temp -- those are very likely false positive.

Currently a broken code at the end will cancel repeats and abort, right? Might be better to just find the most repeated row with bitbuffer_find_repeated_row(), e.g.

int min_repeats = MAX(3, bitbuffer->num_rows / 2 + 1);
int row = bitbuffer_find_repeated_row(bitbuffer, min_repeats, 24);

@zuckschwerdt
Copy link
Collaborator

The "model" needs to be"RF-T0912" -- our rule is alphanum+ - alphanum+

@eshaz
Copy link
Contributor Author

eshaz commented Dec 4, 2023

The "model" needs to be"RF-T0912" -- our rule is alphanum+ - alphanum+

I was just looking at this. There are no labels on the device, other than the FCC ID which I had to look up in their database to get the model number. Wondering if it makes sense to allow more description here so it's easier to identify this device in the rtl_433 output?

@merbanan
Copy link
Owner

merbanan commented Dec 4, 2023

The documentation line should have the "Remote Grill Thermometer" name and the short model name.

@eshaz
Copy link
Contributor Author

eshaz commented Dec 5, 2023

The documentation line should have the "Remote Grill Thermometer" name and the short model name.

I'll make the change, but I still think could be confusing to omit this data from the event. Is there any place where I can add a "Remote Grill Thermometer" description on the output data for the decode events?

@eshaz
Copy link
Contributor Author

eshaz commented Dec 5, 2023

I did some more testing with the device and it appears to support a two byte temperature range (around 9F to 410F) and also uses checksum validation, which makes more sense than what I previously thought. I've added these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants