Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Thermor DG950 Weather Station #2886

Merged
merged 1 commit into from
Mar 30, 2024
Merged

Conversation

ProfBoc75
Copy link
Collaborator

Related to issue #2879

@ProfBoc75 ProfBoc75 linked an issue Mar 25, 2024 that may be closed by this pull request
@NicolasGagne
Copy link

I have tested this pull request

Here is the actual look
Thermor

Observation:

  • ID: OK 100% match
  • Temp: OK 100% match
  • Wind Direction: 100% match
  • Wind speed: the actual reception unit is on average .1 kph below the given rtl_433 value. (sometime .2 below)
  • Rain: Since the transmission unit include only the number of pulse since the last transmission it doesn't give average over the hours but only the average over the last 2 minutes. It seem to transmit the good number of pulse.

Thanks again for you help.

@ProfBoc75
Copy link
Collaborator Author

ProfBoc75 commented Mar 30, 2024

* Wind speed: the actual reception unit is on average .1 kph below the given rtl_433 value. (sometime .2 below)

Thanks @NicolasGagne for the feedback.

If you agree and acceptable for you, I will merge this PR to rtl_433 master and close the issue.

If you found a better formula, do not hesitate to share, Wind Speed is calculate in lines 164 to 171.

@NicolasGagne
Copy link

Sorry I should have said it. It is totally acceptable.

Please merge to master and close the issue.
Thanks

@ProfBoc75 ProfBoc75 merged commit 9448d42 into master Mar 30, 2024
12 checks passed
@ProfBoc75 ProfBoc75 deleted the feat-thermor branch April 1, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Thermor DG950 weather station
2 participants