Update date handling to use dayjs #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucmantovani
requested changes
Jul 17, 2023
There was a problem hiding this comment.
Hello @jlucaso1!
Thank you for your contribution!
I just left a single suggestion to maintain the standard we are already using at the SDK
As soon as you do the adjustment we could proceed with this PR
Co-authored-by: Lucas Mantovani <lucas.mantovani@mercadolivre.com>
lucmantovani
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cambios realizados para el feature:
This pull request updates the codebase to replace the usage of the deprecated moment library with the modern dayjs library for handling dates and times. This update ensures better performance, improved maintenance, and adherence to the latest best practices in date handling.
Checklist validación PR: