Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix $city type #493

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Fix $city type #493

merged 1 commit into from
Jan 12, 2024

Conversation

rhames07
Copy link
Contributor

Changes made to the feature:

  • Fix $city type. This field is returned as a JSON with id and name in the customer/search response.
    The Address object is used in other responses, but any city parameter is returned.

General changes

  • Changes $city type from ?string to array|object|null and maps to new Common\City class.

Issues closed

PR validation checklist:

  • Title and clear description of the PR
  • Tests of my functionality
  • Documentation of my functionality
  • Tests executed and passed

@rhames07 rhames07 added the Fix label Jan 11, 2024
@rhames07 rhames07 merged commit 6a962f5 into master Jan 12, 2024
1 check passed
@rhames07 rhames07 deleted the fix/update-city-type branch January 12, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucmantovani lucmantovani lucmantovani approved these changes

@gdeandradero gdeandradero gdeandradero approved these changes

@delias-silva delias-silva Awaiting requested review from delias-silva

@brunacamposxx brunacamposxx Awaiting requested review from brunacamposxx

@romerosilva-meli romerosilva-meli Awaiting requested review from romerosilva-meli

@eltinMeli eltinMeli Awaiting requested review from eltinMeli

Assignees
No one assigned
Labels
Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rhames07 @lucmantovani @gdeandradero