Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve UUID generation method #514

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Improve UUID generation method #514

merged 1 commit into from
Jun 20, 2024

Conversation

leonardobuares
Copy link
Contributor

This pull request updates the UUID generation function for the X-Idempotency-Key.

Changes made to the feature:

  • Updated the UUID generation function to use random_bytes instead of mt_rand for more reliable randomness.

General changes

  • Adopted a more modern approach to random number generation.

PR validation checklist:

  • Title and clear description of the PR
  • Tests of my functionality
  • Documentation of my functionality
  • Tests executed and passed
  • Branch Coverage >= 80%

@mariannebiancamb
Copy link

Hello, Leonardo
We will analyze the proposed solution and soon integrate it into our product.
Thank you very much for your contribution!

@danielen-meli danielen-meli merged commit b29a126 into mercadopago:master Jun 20, 2024
@danielen-meli danielen-meli mentioned this pull request Jun 20, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielen-meli danielen-meli danielen-meli approved these changes

@eltinMeli eltinMeli Awaiting requested review from eltinMeli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leonardobuares @mariannebiancamb @danielen-meli