Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log flags are missing #28

Closed
H777K opened this issue Nov 29, 2023 · 0 comments · Fixed by #85
Closed

log flags are missing #28

H777K opened this issue Nov 29, 2023 · 0 comments · Fixed by #85
Assignees

Comments

@H777K
Copy link
Member

H777K commented Nov 29, 2023

Since we have merged the PR #24 , we can no longer use the --log* and -v flags to specify the logging behaviour of the garm-operator.

In release v0.1.2 there were the following log flags:

./bin/manager -h
Usage of ./bin/manager:
      --add_dir_header                     If true, adds the file directory to the header of the log messages
      --alsologtostderr                    log to standard error as well as files (no effect when -logtostderr=true)
      --garm-password string               The password for the GARM server
      --garm-server string                 The address of the GARM server
      --garm-username string               The username for the GARM server
      --health-probe-bind-address string   The address the probe endpoint binds to. (default ":8081")
      --kubeconfig string                  Paths to a kubeconfig. Only required if out-of-cluster.
      --leader-elect                       Enable leader election for controller manager. Enabling this will ensure there is only one active controller manager.
      --log_backtrace_at traceLocation     when logging hits line file:N, emit a stack trace (default :0)
      --log_dir string                     If non-empty, write log files in this directory (no effect when -logtostderr=true)
      --log_file string                    If non-empty, use this log file (no effect when -logtostderr=true)
      --log_file_max_size uint             Defines the maximum size a log file can grow to (no effect when -logtostderr=true). Unit is megabytes. If the value is 0, the maximum file size is unlimited. (default 1800)
      --logtostderr                        log to standard error instead of files (default true)
      --metrics-bind-address string        The address the metric endpoint binds to. (default ":8080")
      --namespace string                   Namespace that the controller watches to reconcile garm objects. If unspecified, the controller watches for garm objects across all namespaces.
      --one_output                         If true, only write logs to their native severity level (vs also writing to each lower severity level; no effect when -logtostderr=true)
      --skip_headers                       If true, avoid header prefixes in the log messages
      --skip_log_headers                   If true, avoid headers when opening log files (no effect when -logtostderr=true)
      --stderrthreshold severity           logs at or above this threshold go to stderr when writing to files and stderr (no effect when -logtostderr=true or -alsologtostderr=false) (default 2)
      --sync-period duration               The minimum interval at which watched resources are reconciled (e.g. 15m) (default 5m0s)
  -v, --v Level                            number for the log level verbosity
      --vmodule moduleSpec                 comma-separated list of pattern=N settings for file-filtered logging
pflag: help requested

We probably don't need all log flags, so we should consider which ones are necessary and should be implemented.

@H777K H777K self-assigned this Jan 24, 2024
@H777K H777K closed this as completed in #85 Feb 8, 2024
H777K added a commit that referenced this issue Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant