Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing scaling default value #45

Merged
merged 1 commit into from
Dec 21, 2023
Merged

fix: add missing scaling default value #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions api/v1alpha1/pool_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,16 +18,17 @@ import (
// +kubebuilder:validation:XValidation:rule="self.minIdleRunners <= self.maxRunners",message="minIdleRunners must be less than or equal to maxRunners"
type PoolSpec struct {
// Defines in which Scope Runners a registered. Has a reference to either an Enterprise, Org or Repo CRD
GitHubScopeRef corev1.TypedLocalObjectReference `json:"githubScopeRef"`
ProviderName string `json:"providerName"`
MaxRunners uint `json:"maxRunners"`
MinIdleRunners uint `json:"minIdleRunners"`
Flavor string `json:"flavor"`
OSType commonParams.OSType `json:"osType"`
OSArch commonParams.OSArch `json:"osArch"`
Tags []string `json:"tags"`
Enabled bool `json:"enabled"`
RunnerBootstrapTimeout uint `json:"runnerBootstrapTimeout"`
GitHubScopeRef corev1.TypedLocalObjectReference `json:"githubScopeRef"`
ProviderName string `json:"providerName"`
MaxRunners uint `json:"maxRunners"`
// +kubebuilder:default=0
MinIdleRunners uint `json:"minIdleRunners"`
Flavor string `json:"flavor"`
OSType commonParams.OSType `json:"osType"`
OSArch commonParams.OSArch `json:"osArch"`
Tags []string `json:"tags"`
Enabled bool `json:"enabled"`
RunnerBootstrapTimeout uint `json:"runnerBootstrapTimeout"`

// The name of the image resource, this image resource must exists in the same namespace as the pool
ImageName string `json:"imageName"`
Expand Down
1 change: 1 addition & 0 deletions config/crd/bases/garm-operator.mercedes-benz.com_pools.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ spec:
maxRunners:
type: integer
minIdleRunners:
default: 0
type: integer
osArch:
type: string
Expand Down