fix: reject pool creation if pool with spec exists #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch, for some reason I didn´t think about it once maigl contributet the image cr. Also great to have tests for the filter functions in place. I like :) 👍🏻 |
bavarianbidi
force-pushed
the
fix_pool_validation_logic
branch
from
c2bfa23 to
eb68eb2
Compare
rafalgalaw
approved these changes
Sep 18, 2023
bavarianbidi
force-pushed
the
fix_pool_validation_logic
branch
from
eb68eb2 to
353ed2b
Compare
in garm, a pool is uniq on imageName, flavor, provider and scope. This fixes the current implementation where we compared the image.tag name with the name of the image referenc itself. Signed-off-by: Mario Constanti <mario.constanti@mercedes-benz.com>
bavarianbidi
force-pushed
the
fix_pool_validation_logic
branch
from
353ed2b to
fc58124
Compare
maigl
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in garm, a pool is uniq on imageName, flavor, provider and scope. This fixes the current implementation where we compared the image.tag name with the name of the image referenc itself.
fixes #2