Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sample kube-state-metrics-config #75

Merged
merged 7 commits into from
Feb 29, 2024

Conversation

rafalgalaw
Copy link
Collaborator

@rafalgalaw rafalgalaw commented Jan 16, 2024

  • Added sample config map for exposing garm-operator cr metrics via kube-state-metrics agent
  • Added documentation on metrics and how to use config

@bavarianbidi
Copy link
Member

@rafalgalaw could you also add some more details to the documentation (+ a bunch of example metrics?)

@rafalgalaw rafalgalaw marked this pull request as ready for review February 27, 2024 07:42
Copy link
Member

@bavarianbidi bavarianbidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Once #86 got merged we should add the conditions as metric as well

rafalgalaw and others added 2 commits February 28, 2024 15:31
Adds []metav1.Condition property to the status subresource of pools, enterprise, org and repo
@rafalgalaw
Copy link
Collaborator Author

LGTM

Once #86 got merged we should add the conditions as metric as well

fixed with e7cc308

@rafalgalaw rafalgalaw force-pushed the feat/kube-state-metrics-cm branch from e7cc308 to 654d5af Compare February 28, 2024 15:31
@rafalgalaw rafalgalaw merged commit ca4d50d into main Feb 29, 2024
3 checks passed
@rafalgalaw rafalgalaw deleted the feat/kube-state-metrics-cm branch February 29, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants