Drive by fixes #1 #208
Merged
Drive by fixes #1 #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since all fields are data object properties, they are coded using `ValueParameter` and a lot of complexity can be avoided in not handling them separately in the en-/decoding logic... Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Gerrit Ecke <gerrit.ecke@mbition.io>
…eter to be `None` in this case, the result returned will most likely be incorrect... Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Gerrit Ecke <gerrit.ecke@mbition.io>
that's because according to the ODX specification, requests and responses are *not* structures! (TODO: reflect this in the python code.) Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Gerrit Ecke <gerrit.ecke@mbition.io>
… MatchingRequestParameter this enables better type checking and is the right way to do this in general... Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Gerrit Ecke <gerrit.ecke@mbition.io>
…d for a service Although technically allowed, a service without a request is like computer without RAM... Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Gerrit Ecke <gerrit.ecke@mbition.io>
this allows mypy to check that the attributes and properties called actually exist instead of complaining. Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Gerrit Ecke <gerrit.ecke@mbition.io>
previously this lead to quite a few complaints... Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Gerrit Ecke <gerrit.ecke@mbition.io>
curtsey of `ruff`... Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Gerrit Ecke <gerrit.ecke@mbition.io>
andlaus
force-pushed
the
drive_by_fixes_1
branch
3 times, most recently
from
fa99534 to
b5734cb
Compare
version.py is auto-generated and we can do little if the modules which we rely on do not provide type annotations... Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Gerrit Ecke <gerrit.ecke@mbition.io>
andlaus
force-pushed
the
drive_by_fixes_1
branch
4 times, most recently
from
057d572 to
f2bbdc5
Compare
the arguments have become superfluous because we specify the them via `pyproject.toml` now... Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Gerrit Ecke <gerrit.ecke@mbition.io>
andlaus
force-pushed
the
drive_by_fixes_1
branch
from
f2bbdc5 to
7b813c8
Compare
kayoub5
reviewed
Sep 21, 2023
kayoub5
reviewed
Sep 21, 2023
as usual, the merrits go to [at]kayoub5. Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Gerrit Ecke <gerrit.ecke@mbition.io>
kayoub5
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists of fixes for issues I've noticed while preparing #203. It turned out to be quite a bit larger than the motivating PR...
(note: all patches of this PR are fully self-contained and the PR is also bisectable. Since all commits should be basically independent of each other, it is probably easier to review the PR by looking at the patches individually instead of the cumulative diff.)
Andreas Lauser <andreas.lauser@mercedes-benz.com>, on behalf of MBition GmbH.
Provider Information