Add type annotations, part 2 #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update table of contents - remove duplicate License section Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Christian Hackenbeck <christian.hackenbeck@mbition.io> Signed-off-by: Alexander Walz <alexander.walz@mbition.io>
there's still `.get_coded_value_as_bytes(encode_state)`, but that one is most definitely used. Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Christian Hackenbeck <christian.hackenbeck@mbition.io> Signed-off-by: Alexander Walz <alexander.walz@mbition.io>
for whatever reason, mypy did not complain about these last time... Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Christian Hackenbeck <christian.hackenbeck@mbition.io> Signed-off-by: Alexander Walz <alexander.walz@mbition.io>
Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Christian Hackenbeck <christian.hackenbeck@mbition.io> Signed-off-by: Alexander Walz <alexander.walz@mbition.io>
Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Christian Hackenbeck <christian.hackenbeck@mbition.io> Signed-off-by: Alexander Walz <alexander.walz@mbition.io>
Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Christian Hackenbeck <christian.hackenbeck@mbition.io> Signed-off-by: Alexander Walz <alexander.walz@mbition.io>
Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Christian Hackenbeck <christian.hackenbeck@mbition.io> Signed-off-by: Alexander Walz <alexander.walz@mbition.io>
Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Christian Hackenbeck <christian.hackenbeck@mbition.io> Signed-off-by: Alexander Walz <alexander.walz@mbition.io>
Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Christian Hackenbeck <christian.hackenbeck@mbition.io> Signed-off-by: Alexander Walz <alexander.walz@mbition.io>
Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Christian Hackenbeck <christian.hackenbeck@mbition.io> Signed-off-by: Alexander Walz <alexander.walz@mbition.io>
Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Christian Hackenbeck <christian.hackenbeck@mbition.io> Signed-off-by: Alexander Walz <alexander.walz@mbition.io>
kayoub5
reviewed
Sep 27, 2023
kayoub5
reviewed
Sep 27, 2023
kayoub5
reviewed
Sep 27, 2023
kayoub5
reviewed
Sep 27, 2023
kayoub5
reviewed
Sep 27, 2023
kayoub5
reviewed
Sep 27, 2023
andlaus
force-pushed
the
add_type_annotations_2
branch
3 times, most recently
from
8e2ef5e to
9ca3ea5
Compare
thanks to [at]kayoub5 for the suggestion! Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Christian Hackenbeck <christian.hackenbeck@mbition.io> Signed-off-by: Alexander Walz <alexander.walz@mbition.io>
As usual the thanks go to [at]kayoub5! Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Christian Hackenbeck <christian.hackenbeck@mbition.io> Signed-off-by: Alexander Walz <alexander.walz@mbition.io>
andlaus
force-pushed
the
add_type_annotations_2
branch
from
9ca3ea5 to
cf061ff
Compare
kayoub5
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second part of the quest for comprehensive type annotations. Besides the on-topic changes, it also contains a minor cleanup of the README, and the removal of the completely unused but confusingly named
Parameter.get_coded_value()method.Andreas Lauser <andreas.lauser@mercedes-benz.com>, on behalf of MBition GmbH.
Provider Information