Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get ready for release #221

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Conversation

andlaus
Copy link
Collaborator

@andlaus andlaus commented Oct 17, 2023

This PR enables the --disallow-untyped-defs mypy option by default, and adds back the Message.structure attribute as a deprecated alias for Message.coding_object (this should significantly reduce the pain of upgrading from an older version).

Andreas Lauser <andreas.lauser@mercedes-benz.com>, on behalf of MBition GmbH.
Provider Information

this makes mypy much more strict...

Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io>
Signed-off-by: Gerrit Ecke <gerrit.ecke@mbition.io>
this keeps older code working. we *really* don't want to call this
attribute `.structure` because in the ODX specification, requests and
responses are _not_ structures...

Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io>
Signed-off-by: Gerrit Ecke <gerrit.ecke@mbition.io>
@andlaus andlaus requested a review from kayoub5 October 17, 2023 09:00
@andlaus andlaus merged commit b0dbaab into mercedes-benz:main Oct 17, 2023
6 checks passed
@andlaus andlaus deleted the add_type_annotations_9 branch December 7, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants