diag_layer: allow to access services according to their UDS service group (SID) #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andlaus
force-pushed
the
uds_binner
branch
3 times, most recently
from
f8296c4 to
e3fa99c
Compare
kayoub5
reviewed
Oct 20, 2023
kayoub5
reviewed
Oct 20, 2023
odxtools/udsbinner.py
Outdated
| sid_to_name = { | ||
| # diagnostic services that cannot be categorized in terms of | ||
| # the UDS standard get `None` as their SID... | ||
| None: "Not Applicable", |
There was a problem hiding this comment.
Suggested change
| None: "Not Applicable", | |
| None: "Unknown", |
There was a problem hiding this comment.
IMO, in this case, "not applicable" is -- err -- more applicable: This is meant for all services which do not conform to the UDS specification at all, i.e., the first byte of their request cannot be statically determined. "Unknown" SIDs are SIDs which have not (yet?) been specified by UDS (or ones which I missed to add...)
There was a problem hiding this comment.
- there are other standard diag services other than UDS, for example OBD II (range 1 to 0xa)
- assigning all services that you don't recognize the same name is not nice, instead return sid as hex
There was a problem hiding this comment.
I refactored the code a bit. I hope these issues are solved with that...
kayoub5
reviewed
Oct 20, 2023
kayoub5
reviewed
Oct 20, 2023
kayoub5
reviewed
Oct 21, 2023
odxtools/udsbinner.py
Outdated
| """ | ||
| result = StringIO() | ||
| for sid, service_list in self.service_groups.items(): | ||
| sid_name = self.sid_to_name.get(sid) |
There was a problem hiding this comment.
will throw for unknown service,
Suggested change
| sid_name = self.sid_to_name.get(sid) | |
| sid_name = self.sid_to_name.get(sid, hex(sid)) |
There was a problem hiding this comment.
I refactored this code with the goals of including the OBD services and using the existing .uds and .obd sub-packages...
Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Alexander Walz <alexander.walz@mbition.io>
… determine the size this is the intended mechanism for this. Retrieving the `.bit_length` attribute from the objects where it is available is a pretty fragile hack... Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Alexander Walz <alexander.walz@mbition.io>
…ce group (SID)
This is a convenience functionality to quickly find the diagnostic
services one is interested in for ECUs offering lots of services. The
simplest way to use it is using the `.print_info()` method:
```python
ecu.uds_service_groups.print_info()
```
That said, bins can also be programmatically processed:
```python
session_services = ecu.uds_service_groups[0x10]
print("The services concerning diagnostic sessions are:")
for session in session_services:
print(f" {service.short_name}")
```
Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io>
Signed-off-by: Alexander Walz <alexander.walz@mbition.io>
thanks, [at]kayoub5! Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Alexander Walz <alexander.walz@mbition.io>
- also categorize OBD services. As a consequence, rename the class from `UdsServiceBinner` to `ServiceBinner` - use the `.obd` and `.uds` sub-packages - add `__repr__()` and `__iter__()` methods Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Alexander Walz <alexander.walz@mbition.io>
kayoub5
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a convenience functionality to quickly find the diagnostic services one is interested in for ECUs offering lots of services. The simplest way to use it is using the
.print_info()method:That said, bins can also be programmatically processed:
Andreas Lauser <andreas.lauser@mercedes-benz.com>, on behalf of MBition GmbH.
Provider Information