Split find into find and decode #227
Conversation
floroks
force-pushed
the
fix_find_command
branch
2 times, most recently
from
2180232 to
608f31e
Compare
odxtools/cli/decode.py
Outdated
| "", | ||
| "Examples:", | ||
| " For displaying the service associated with the request 10 01 & decoding it:", | ||
| " odxtools decode ./path/to/database.pdx -d 10 01", |
There was a problem hiding this comment.
| " odxtools decode ./path/to/database.pdx -d 10 01", | |
| " odxtools decode ./path/to/database.pdx -d '10 01'", |
There was a problem hiding this comment.
oops, yes, thanks, i fixed it to work with -d 10 01 again. -D is a modifier to additionally decode it, although maybe it might be better to just differentiate between -d 10 01 and -D 10 01 - thoughts?
There was a problem hiding this comment.
allowing the data to be specified as multiple arguments is a bad idea IMO, see below...
odxtools/cli/decode.py
Outdated
| " For more information use:", | ||
| " odxtools decode -h", | ||
| ]), | ||
| help="Find & print services by hex-data, or name. Can also decode the request.", |
There was a problem hiding this comment.
that seems to be not correct after this PR anymore?
There was a problem hiding this comment.
oops, yes, thanks, i fixed it to be accurate again
tests/test_cli.py
Outdated
| UtilFunctions.run_find_tool(service_names=["headstand"], allow_unknown_bit_lengths=True) | ||
| UtilFunctions.run_find_tool( | ||
| service_names=["headstand"], allow_unknown_bit_lengths=True, no_details=True) | ||
| # UtilFunctions.run_find_tool(service_names="3e00") |
There was a problem hiding this comment.
avoid commented-out code if there's not a very good reason for it...
floroks
force-pushed
the
fix_find_command
branch
from
608f31e to
c98ab95
Compare
odxtools/cli/decode.py
Outdated
| parser.add_argument( | ||
| "-d", | ||
| "--data", | ||
| nargs="*", |
There was a problem hiding this comment.
I'd vastly prefer to make this a simple string, because right now specifying positional arguments after -d makes things quite iffy (e.g. odxtools decode -d 01 01 my_file.pdx will fail while odxtools decode -d "01 01" my_file.pdx will work just fine if --data was a simple string parameter).
| nargs="*", |
floroks
force-pushed
the
fix_find_command
branch
4 times, most recently
from
8f70b3f to
ea8ff17
Compare
|
okay, looks good to me now. A small thing which I've noticed while playing with it: if the data is specified using an illegal format (e.g. |
…search functionality without data for find
floroks
force-pushed
the
fix_find_command
branch
from
ea8ff17 to
9af6441
Compare
|
fixed, I also remove all non-hex-chars from the string, to be more fault-tolerant to the input |
|
ok, thanks! merging. |
Fix issue with find command requiring data, by splitting the decode and find (by service name) functionalities
into separate commands.