Fix an issue, in which overlapping parameters were shown separately #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
floroks
force-pushed
the
fix_overlapping_parameters_display
branch
5 times, most recently
from
05e3c83 to
ed1cac0
Compare
andlaus
reviewed
Oct 21, 2023
odxtools/basicstructure.py
Outdated
| @@ -411,6 +422,17 @@ def param_sort_key(param: Parameter) -> Tuple[int, int]: | |||
| formatted_lines.append(next_line) | |||
| next_line = "" | |||
|
|
|||
| if 0 < param_idx < len(params) - 1 and hasattr( | |||
There was a problem hiding this comment.
I prefer range checks to be oldschool:
Suggested change
| if 0 < param_idx < len(params) - 1 and hasattr( | |
| if 0 < param_idx and param_idx < len(params) - 1 and hasattr( |
(while a < x < b works with python it feels too magical to me because (a < x) < b will not work in all cases)...
Overlapping parameters happen when you define parameters with different bit-lengths at the same byte-position.
floroks
force-pushed
the
fix_overlapping_parameters_display
branch
from
ed1cac0 to
f6bf2e9
Compare
|
ok, thanks; merging. (note to myself: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue, in which overlapping parameters were shown separately
Overlapping parameters happen when you define parameters with different bit-lengths at the same byte-position.
Example:
Define parameter X at position 3 with bit-length 24
Define parameter Y at position 3 with bit-length 8
Define parameter Z at position 4 with bit-length 8
Define parameter A at position 5 with bit-length 8