fix ComplexComparam from_et function
#237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andlaus
reviewed
Nov 8, 2023
There was a problem hiding this comment.
Thanks for the patch. besides my usual nitpicks it looks good!
Before it can be merged, you need to sign the CLA. (please put me into the CC of the email: andreas.lauser@mercedes-benz.com)
andlaus
reviewed
Nov 8, 2023
address review comments
willzhang05
force-pushed
the
fix-complex-comparam
branch
from
096c342 to
16aec74
Compare
|
okay, I've received the CLA. Let's get this merged. Thanks for the contribution :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #236