SDGs: if the SDG caption is referenced, do not add its IDs to the odxlink database #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…link database This prevents these SDG captions to be added multiple times (i.e., for SDGs which only reference the caption, not define it). Under normal circumstances, this only results in slightly lower performance, but in special situations like having to modify a database based on another, it can lead to SDG captions added which are not defined. (I recently stumbled over such a case.) Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Florian Jost <florian.jost@mbition.io>
andlaus
added a commit
to andlaus/odxtools
that referenced
this pull request
Aug 5, 2024
…t data objects Just like for mercedes-benz#328, under normal circumstances, this only results in slightly lower performance, but in special situations like having to modify a database based on another, it can lead to environment data objects being falsely added. (I recently stumbled over such a case.) Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Florian Jost <florian.jost@mbition.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents these SDG captions to be added multiple times (i.e., for SDGs which only reference the caption but do not define it). Under normal circumstances, this only results in slightly lower performance, but in special situations like having to modify a database, it can lead to SDG captions added which are defined nowhere. (I recently stumbled over such a case.)
Andreas Lauser <andreas.lauser@mercedes-benz.com>, on behalf of MBition GmbH.
Provider Information