Random fixes #330
Merged
Random fixes #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
these values might be strings and thus might contain special characters that must be escaped. (I recently fell on my face because of this.) Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io>
instead of the representation of `CompuConst`, it is much better to print the values expected/produced by the encoding/decoding routines. Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Florian Jost <florian.jost@mbition.io>
|
since this is "obviously correct" (value escaping fix) and at best a question of preference (the CompuConst output improvement), I'll merge this without bothering for a review. @kayoub5: If for some strange reason I'm wrong and you would like to see changes to this, I'm happy to implement them in a separate PR... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a fix for the output writing code (the values of limits might be strings with special characters and must thus be escaped) and for the function which summarizes the expected parameters of codec objects (we don't want to see the representation of
CodedConstobjects there).Andreas Lauser <andreas.lauser@mercedes-benz.com>, on behalf of MBition GmbH.
Provider Information