Fix the document fragments for objects not featured by the base diag layer #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…layer since diag layers constitute a document fragment in addition to the container which contains them, the odxlink ids must reflect that. So far, this did not happen for objects which are added by one of the concrete diagnostic layers classes, i.e. objects which were not handled by the diagnostic layer base class. Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Christian Hackenbeck <christian.hackenbeck@mbition.io>
|
this might fix #342, but probably it won't. (that said, while doing this PR, I verified that ECU-SHARED-DATA diaglayers can be referenced via their layer document fragment in IMPORT-REFs.) |
kayoub5
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since diagnostic layers constitute document fragments in addition to the containers which contain them, the odxlink ids must reflect that. So far, this did not happen for objects which are added by one of the concrete diagnostic layers classes, i.e. objects which were not handled by the diagnostic layer base class.
Andreas Lauser <andreas.lauser@mercedes-benz.com>, on behalf of MBition GmbH.
Provider Information