Fix #748 Ensure FederatedError errors argument is an array.
#749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add constructor argument validation to `FederatedError` to ensure `errors` is an Array * Add input validation tests for FederatedError constructor argument * Fix `request` and `sendRequest` to wrap caught errors in array when creating new `FederatedError` * Add new test file for `request` to ensure array is used * Modify existing `sendRequest` test to verify array is used * Add support for passing in undici agent as part of the federated service configuration. Required for injection during tests. See nodejs/undici#996
|
Could you please document the new agent option? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FederatedErrorto ensureerrorsis an ArrayrequestandsendRequestto wrap caught errors in array when creating newFederatedErrorrequestto ensure array is usedsendRequesttest to verify array is usedFixes #748