Keep requires directive in gateway schema #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleccool213
commented
Mar 18, 2022
| @@ -710,16 +710,6 @@ test('Polling schemas (should properly regenerate the schema when a downstream s | |||
| }) | |||
| t.teardown(() => clock.uninstall()) | |||
| const oldSchema = ` | |||
| directive @extends on INTERFACE | OBJECT | |||
There was a problem hiding this comment.
It doesn't make sense for a service to have this defined in its schema. This is federation metadata.
aleccool213
commented
Mar 18, 2022
| @@ -804,16 +794,6 @@ test('Polling schemas (should properly regenerate the schema when a downstream s | |||
| }) | |||
|
|
|||
| const refreshedSchema = ` | |||
| directive @extends on INTERFACE | OBJECT | |||
There was a problem hiding this comment.
It doesn't make sense for a service to have this defined in its schema. This is federation metadata.
|
@jonnydgreen could you take a look as well? |
|
Since it's a bugfix, I'm thinking we should backport this to v8 as well - what do you think @mcollina? |
|
Great idea, let's try the action. |
mcollina
pushed a commit
that referenced
this pull request
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #729