Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hooks types #891

Merged
merged 3 commits into from
Oct 14, 2022
Merged

Fix hooks types #891

merged 3 commits into from
Oct 14, 2022

Conversation

sameer-coder
Copy link
Contributor

@sameer-coder sameer-coder commented Oct 12, 2022 •
edited
Loading

This PR updates types related to various hooks

Closes #877

cc @simoneb

@sameer-coder sameer-coder changed the title Fix pre-execution hook types Fix hook types Oct 12, 2022
@sameer-coder sameer-coder changed the title Fix hook types Fix hooks types Oct 12, 2022
jonnydgreen
jonnydgreen reviewed Oct 12, 2022
View reviewed changes
Copy link
Contributor

@jonnydgreen jonnydgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - could you add some type tests?

mcollina
mcollina requested changes Oct 13, 2022
View reviewed changes
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add the tests?

mcollina
mcollina approved these changes Oct 14, 2022
View reviewed changes
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 1cbb5ef into mercurius-js:master Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@jonnydgreen jonnydgreen Awaiting requested review from jonnydgreen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect overload types of hooks
3 participants
@sameer-coder @mcollina @jonnydgreen