Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly say in the docs that JIT is disabled by default #901

Merged
merged 1 commit into from
Nov 2, 2022

Conversation

igrlk
Copy link
Contributor

@igrlk igrlk commented Oct 29, 2022

I think that's a good thing to mention that JIT is disabled by default and should be explicitly enabled to get the performance benefits. I personally thought that it's enabled by default, but then I started digging into Mercurius and found how JIT is actually used there, and that it's not enabled by default.

Screenshot of the updated docs:
Screenshot 2022-10-29 at 21 21 04

@igrlk
Copy link
Contributor Author

igrlk commented Oct 29, 2022

Also curious, why not is not enabled by default? Interesting to hear code owners vision on things like JIT and other plugins - are they just an addition or things like jit considered as main features?

Really keen to know what you think about it, especially because of @defer in Mercurius PR that's kind of blocked by JIT not working properly with @defer - should it be even considered as blocker or no?

@smolinari
Copy link
Contributor

smolinari commented Oct 30, 2022

I personally think JIT is a feature that is a main selling point for Mercurius. It's where it's superior performance comes from. That being said, JIT is only really interesting in a system running in production. As long as code is changing (i.e. during development), JIT is less important. I'm wondering though, does "0" calls of a query to JIT it mean JIT is completely off, or does it mean it is always on? 😁

But for sure, it would be a good idea to mention it being "0" as default (and note what that means), since all defaults should be mentioned for configs and most are for the other plugin options.

Scott

Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 780c668 into mercurius-js:master Nov 2, 2022
@igrlk igrlk deleted the fix/jit-default-state-docs branch November 2, 2022 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants