Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export SubscriptionClient class #920

Closed
wants to merge 1 commit into from

Conversation

codeflyer
Copy link
Contributor

in this PR:

  • Export the SubscriptionClient
  • update the type definitions
  • add test to the types exported

@mcollina
Copy link
Collaborator

I would rather export it in a separate module instead. Wdyt?

@codeflyer
Copy link
Contributor Author

I would rather export it in a separate module instead. Wdyt?

You mean export just the Subscription Client? Or all the subscription feature?

In the first case we can build a module like @mercurius/subscription-tools and use them directly in the mercurius part that manage the subscription.

I wont extract instead the feature completely.

Wdyt?

@mcollina
Copy link
Collaborator

I would extract only the SubscriptionClient.

@marco-ippolito
Copy link
Contributor

I would extract only the SubscriptionClient.

this is being done here mercurius-js/mercurius-subscription-client#3

@marco-ippolito
Copy link
Contributor

@mcollina @codeflyer we can close this has has been resolved by #938

@mcollina mcollina closed this Jan 6, 2023
@simoneb simoneb deleted the feat/export-subscription-client branch November 15, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants