enable diagnostic counters without debug #782
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
@soumagne: Are these build failures expected? Glancing through them, it seems like an environmental issue (can't find MPI compiler?). |
CMakeLists.txt
Outdated
| @@ -175,10 +175,22 @@ endif() | |||
| option(MERCURY_ENABLE_DEBUG "Enable debug statements." OFF) | |||
| if(MERCURY_ENABLE_DEBUG) | |||
| set(HG_HAS_DEBUG 1) | |||
| set(HG_HAS_DIAG 1) | |||
There was a problem hiding this comment.
I think here you should do instead (so that there is no conflict with the value of HG_HAS_DIAG):
# Always enable counters if debug is turned ON
set(MERCURY_ENABLE_COUNTERS "ON" CACHE BOOL "Enable diagnostics counters (enabled with debug)." FORCE)
Yes, please rebase on top of latest master to pickup CI fixes. Also if you don't mind please add the prefix |
|
(oh and last thing, because you've signed the CLA, you don't need to sign off the commit) |
In some cases, it may be useful to enable the counters without enabling the full debugging configuration.
mjmac
force-pushed
the
enable-diag-ctrs
branch
from
a94d9f6 to
adde681
Compare
In some cases, it may be useful to enable the counters without
enabling the full debugging configuration.
Signed-off-by: Michael MacDonald mjmac@google.com