Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2643 update perms #467

Merged
merged 12 commits into from
Oct 28, 2021
Merged

2643 update perms #467

merged 12 commits into from
Oct 28, 2021

Conversation

sanjuroj
Copy link
Contributor

No description provided.

Sanjuro Jogdeo and others added 12 commits September 10, 2021 16:31
progress
0c65edf
Add git hub ticket url, add ability to select multiple columns.
2722e5a
@sanjuroj
Merge pull request #463 from mercycorps/updateGHscript
0e01560 
Update github script
Update translation documentation, tweak creat_temp_translation command.
ba381f3
Update translation documentation, move translator files into repo.
6e6082f
Update translation documentation, tweak translation doc.
ca16898
@sanjuroj
Merge pull request #464 from mercycorps/2608-transDocs
2e6d9e9 
2608 trans docs
For 2642, fix superuser access issues to disaggs and country strategi…
b249357 
…c objectives on indicator form.
For 2642, fix test.
d344f7d
@sanjuroj
Merge pull request #465 from mercycorps/2642-disaggPerms
eb93925 
2642 disagg perms
For mercycorps/TolaActivity#2643, working permission file updater.
b619ee1
For mercycorps/TolaActivity#2643, enhance permission writer and add t…
514a8b9 
…ests.
@sanjuroj sanjuroj requested a review from andrethomas6 October 28, 2021 05:49
@github-actions
Copy link

This is your code review checklist:

  • Are unit tests written for all Python logic?
  • Are unit tests written for all React components/logic?
  • Are all user-facing strings marked for translation?
  • Are all translation-marked strings given adequate context notes? wiki
  • Is all rendered output ARIA/Accessibility friendly?

@sanjuroj
Copy link
Contributor Author

@andrethomas6 Note that this is being merged to staging so we can release it next week. There's untested code on the dev branch that we can't release yet.

@sanjuroj sanjuroj merged commit 40305ab into staging Oct 28, 2021
@axoplasm axoplasm deleted the 2643-updatePerms branch September 23, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrethomas6 andrethomas6 andrethomas6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanjuroj @andrethomas6