Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed React Datepicker and added old datepicker for start and end d… #717

Merged
merged 1 commit into from
Oct 21, 2022
Merged

Removed React Datepicker and added old datepicker for start and end d… #717

merged 1 commit into from
Oct 21, 2022

Conversation

andrethomas6
Copy link
Contributor

Removed React Datepicker and added old datepicker for start and end dates.
Fixed outcome themes hover text.

@github-actions
Copy link

This is your code review checklist:

  • Are unit tests written for all Python logic?
  • Are unit tests written for all React components/logic?
  • Are all user-facing strings marked for translation?
  • Are all translation-marked strings given adequate context notes? wiki
  • Is all rendered output ARIA/Accessibility friendly?

2 similar comments
@github-actions
Copy link

This is your code review checklist:

  • Are unit tests written for all Python logic?
  • Are unit tests written for all React components/logic?
  • Are all user-facing strings marked for translation?
  • Are all translation-marked strings given adequate context notes? wiki
  • Is all rendered output ARIA/Accessibility friendly?

@github-actions
Copy link

This is your code review checklist:

  • Are unit tests written for all Python logic?
  • Are unit tests written for all React components/logic?
  • Are all user-facing strings marked for translation?
  • Are all translation-marked strings given adequate context notes? wiki
  • Is all rendered output ARIA/Accessibility friendly?

blakelong
blakelong approved these changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@blakelong blakelong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I was able to run the build without errors.

@andrethomas6 andrethomas6 merged commit 6b1f9dc into transporter-3.0.0 Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakelong blakelong blakelong approved these changes

@axoplasm axoplasm Awaiting requested review from axoplasm

@kbarkemeyer kbarkemeyer Awaiting requested review from kbarkemeyer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrethomas6 @blakelong