Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed duplicate gait id error handling to prevent submission. #721

Merged
merged 2 commits into from
Oct 24, 2022
Merged

Fixed duplicate gait id error handling to prevent submission. #721

merged 2 commits into from
Oct 24, 2022

Conversation

andrethomas6
Copy link
Contributor

Fixed duplicate gait id error handling to prevent submission.

@github-actions
Copy link

This is your code review checklist:

  • Are unit tests written for all Python logic?
  • Are unit tests written for all React components/logic?
  • Are all user-facing strings marked for translation?
  • Are all translation-marked strings given adequate context notes? wiki
  • Is all rendered output ARIA/Accessibility friendly?

kbarkemeyer
kbarkemeyer approved these changes Oct 24, 2022
View reviewed changes
Copy link
Contributor

@kbarkemeyer kbarkemeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@andrethomas6
Copy link
Contributor Author

Great, thanks!

Great catch! I ended up moving the valid flag into the function to create an error.

@andrethomas6 andrethomas6 merged commit a077431 into transporter-3.0.0 Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbarkemeyer kbarkemeyer kbarkemeyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrethomas6 @kbarkemeyer