ROB: Ensure update_page_form_field_values does not fail if no fields (p…

…y-pdf#1346) Fixes py-pdf#1343
mergezalot · Sep 18, 2022 · 141a765 · 141a765
1 parent 620d2fa
commit 141a765
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/PyPDF2/_writer.py b/PyPDF2/_writer.py
@@ -622,6 +622,9 @@ def update_page_form_field_values(
  """
  self.set_need_appearances_writer()
  # Iterate through pages, update field values
+ if PG.ANNOTS not in page:
+ logger_warning("No fields to update on this page", __name__)
+ return
  for j in range(len(page[PG.ANNOTS])): # type: ignore
  writer_annot = page[PG.ANNOTS][j].get_object() # type: ignore
  # retrieve parent field values, if present

diff --git a/tests/test_writer.py b/tests/test_writer.py
@@ -370,11 +370,17 @@ def test_fill_form():
  page = reader.pages[0]
 
  writer.add_page(page)
+ writer.add_page(PdfReader(RESOURCE_ROOT / "crazyones.pdf").pages[0])
 
  writer.update_page_form_field_values(
  writer.pages[0], {"foo": "some filled in text"}, flags=1
  )
 
+ # check if no fields to fill in the page
+ writer.update_page_form_field_values(
+ writer.pages[1], {"foo": "some filled in text"}, flags=1
+ )
+
  writer.update_page_form_field_values(
  writer.pages[0], {"foo": "some filled in text"}
  )