Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing a classDiagram may crash the browser tab (tab becomes unresponsive) #9

Closed
Treverix opened this issue Jan 15, 2020 · 1 comment

Comments

@Treverix
Copy link

Treverix commented Jan 15, 2020

Adding a class definition to a classDiagram may crash the browser tab so that it becomes unresponsive and has to be closed.
The URL is updated, so if we copy that before closing the tab, we can open the editor again with the full diagram.

Steps to reproduce: With google chrome 79.0.3945.117, live-editor is 8.4.5, enter the following diagram code:

classDiagram
  A-->B
  B-->C
  class B {
   +a()
  }

Now try to enter class A { in a line before class B {. The tab crashes when we enter the {.

Chrome devTools report: "Paused before potential out-of-memory crash".

@ashishjain0512
Copy link
Contributor

It has been fixed and will be available in the 8.4.6 Release.

gukoff added a commit to gukoff/mermaid-live-editor that referenced this issue Mar 17, 2021
Currently building the docker image fails with the following error:

```
 => [mermaid-live-editor-builder 4/5] RUN yarn install                                                                                                                                  25.2s= => ERROR [mermaid-live-editor-builder 5/5] RUN yarn build                                                                                                                               0.8s
------                                                                                                                                                                                         > [mermaid-live-editor-builder 5/5] RUN yarn build:
mermaid-js#9 0.399 yarn run v1.21.1
mermaid-js#9 0.432 $ webpack build
mermaid-js#9 0.748 internal/modules/cjs/loader.js:628
mermaid-js#9 0.748   throw e;
mermaid-js#9 0.748   ^
mermaid-js#9 0.748
mermaid-js#9 0.748 Error: No valid exports main found for '/home/node_modules/colorette'
mermaid-js#9 0.748     at resolveExportsTarget (internal/modules/cjs/loader.js:625:9)
mermaid-js#9 0.748     at applyExports (internal/modules/cjs/loader.js:502:14)
mermaid-js#9 0.748     at resolveExports (internal/modules/cjs/loader.js:551:12)
mermaid-js#9 0.748     at Function.Module._findPath (internal/modules/cjs/loader.js:657:22)
mermaid-js#9 0.748     at Function.Module._resolveFilename (internal/modules/cjs/loader.js:960:27)
mermaid-js#9 0.748     at Function.Module._load (internal/modules/cjs/loader.js:855:27)
mermaid-js#9 0.748     at Module.require (internal/modules/cjs/loader.js:1033:19)
mermaid-js#9 0.748     at require (/home/node_modules/v8-compile-cache/v8-compile-cache.js:159:20)
mermaid-js#9 0.748     at Object.<anonymous> (/home/node_modules/webpack-cli/lib/webpack-cli.js:10:66)
mermaid-js#9 0.748     at Module._compile (/home/node_modules/v8-compile-cache/v8-compile-cache.js:192:30) {
mermaid-js#9 0.748   code: 'MODULE_NOT_FOUND'
mermaid-js#9 0.748 }
mermaid-js#9 0.763 error Command failed with exit code 1.
mermaid-js#9 0.763 info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
------
executor failed running [/bin/sh -c yarn build]: exit code: 1
```

This is because colorette doesn't work with Node.js 13: jorgebucaran/colorette#46

Any node.js other than 13 would work. If there's a reason to not use the latest version, we can change it to 14.16.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants