Skip to content

Commit

Permalink
Merge pull request #300 from LarryKlugerDS/master
Browse files Browse the repository at this point in the history
Issue 299: Sequence diagram Loops: changing boxMargin spoils the "loop" notation
  • Loading branch information
knsv committed Feb 10, 2016
2 parents 193ee65 + 0f7dda9 commit 3ff23b3
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 5 deletions.
10 changes: 7 additions & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,20 +53,24 @@ Fork, then:
npm install
```

Then the dependencies will have been installed. You use gulp as build tool.
Then the dependencies will have been installed. You use gulp and npm calls as build tools.

The following targets are probably interesting:

* jison - compiles the jison grammars to parser files
* dist - complies files to the dist catalog

for instance:
```
gulp jasmine
gulp jison
```
To run the tests:
```
npm run karma
```

To build the /dist directory
```
npm run dist
```

Thanks, Knut Sveidqvist
4 changes: 2 additions & 2 deletions src/diagrams/sequenceDiagram/svgDraw.js
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,8 @@ exports.drawLoop = function(elem,bounds,labelText, conf){
txt.text = labelText;
txt.x = bounds.startx;
txt.y = bounds.starty;
txt.labelMargin = 1.5 * conf.boxMargin;
txt.class = 'labelText';
txt.labelMargin = 1.5 * 10; // This is the small box that says "loop"
txt.class = 'labelText'; // Its size & position are fixed.
txt.fill = 'white';

exports.drawLabel(g,txt);
Expand Down

0 comments on commit 3ff23b3

Please sign in to comment.