-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Truncated text and custom font families #1540
Comments
Thanks for reporting this. They method to get the width of the label is to render it and get the bounding box. After that the width if the box is calculated based in that initial width. If the font for some reason differs between the initial rendering and the final svg the text can be cut. I will try to replicate this error and investigate. This might be related to issue #1485. |
I can see the issue inside Notable. Very nice note application btw! I will start looking into #1485 and see if that gives any insights into this as well. I am available for close collaboration to get this working properly in Notable. If you are interested in that you can join our slack and ping me, knsv. |
I've come across this problem in 8.7.0. I'm using the example to have marked generate output with .mermaid class and then using Mermaid.init(undefined, '.mermaid'); to apply that, given import Mermaid from 'mermaid'; Any idea what's missing here? |
I wonder why this happens. I would love to use Mermaid, but it is unusable with this issue. I tried with all my CSS disabled except for Mermaid's, and it still happens. I really would love to make some node/flow graphs with this! |
I am having similar issue, when I use mermaid in Rmarkdown. When I run the code as a chunck on RStudio, the image is fine. Is this issue same as #1540 or a different issue? Can anyone comment and advise please? |
This is also happening in Notion, with lines getting cut off entirely: The relevant markup: flowchart LR
start --> a1((a1))
a1((a1)) --> 1("lock()\nold := new\nq := q->next")
--> a2((a2)) -->
2[/if q != NULL/] -- TRUE --> a3((a3)) -->
3("q->data := new\nunlock()\nnew++") --> a4((a4)) -->
4[/if new != old/] -- FALSE --> a5((a5)) --> t5("unlock()")
2 -- FALSE --> a4
4 -- TRUE --> a1
Upon inspection, it appears that the |
Maybe a simpler solution would be to be able to configure a padding to account for font rendering discrepancies (between a server and a client)? |
I am not able to repro this in the live editor any more, nor in my local site. Is the base issue reported still an issue? |
I believe that Mermaid live is using client side rendering? It's still an issue when using Mermaid server-side because it will compute the size of the boxes using a different font rendering engine (or even font family) than the one used by the client. |
I was able to overcome this issue in Notion by using
|
Just wanted to mention that I witnessed this challenge as well (outside of Notion) and was able to move forward with non-truncated text rendering using @LukaDarsalia's workaround (adding |
All the given examples are rendering properly now. graph TD
f((f)) --> x((x))
f --> y((y))
y --> t1((t1))
x --> t2((t2))
Mermaid bugOnegraph LR
A{Some Long Text}
A -->|option number one| B[option number one]
A -->|option number two| C[option number two]
Twograph LR
a[Attitude] --> i[Intention]
sn[Subjective norm] --> i
pbc[Perceived behavioral control] --> i
i --> b[Behavior]
pbc --> b
Threegraph LR
sys{"System II (deliberative) decision"} -->|yes| act[Attitude activation] --> inf[Attitude influences behavior]
sys -->|no| acc{Attitude accessibility} -->|low| noact[No attitude activation] --> noinf[Attitude does not influence behavior]
acc -->|high| act
Fourgraph TD
subgraph Coupling
A-->B
C-->B
B-->D
D-->B
end
Fivegraph LR
Power_Supply --> Transmitter_A
Power_Supply --> Transmitter_B
Transmitter_A --> D
Transmitter_B --> D
Sixgraph TB
start-->step_one
start-->testing_a_long_string
step_one-->step_four
start-->step_four
step_four-->finish
testing_a_long_string-->finish
|
It looks like this was either not fully resolved or there has been a regression, see this example: https://codepen.io/the-real_s-h-a-d-o-w/pen/RNbejQq It's running fine in CodePen but if you download it and open it locally, you will very likely see clipping. This can be resolved easily by inserting the following in the render function between adding custom styles and rendering: await new Promise(resolve => {
document.fonts.ready.then(() => {
resolve()
});
}) I thought about just submitting a PR given the simplicity. But there should obviously also be a regression test created, which will take a bit of time. But I'm happy to contribute if you want me to. |
Describe the bug
I can't get Mermaid to not truncate any part of any rendered text. For some context I'm mainly interested in getting Mermaid to work properly inside Notable, of which you can find a version shipping with Mermaid v8.5.2 here, but I can also reproduce some of these issues in the official live editor.
Issue
First of all let's take the following graph as an example:
This is what it looks like under my Windows VM:
The padding is completely off, and for some reason inside the app (which you can kind of see there in the background) the issue is more accentuated 🤷♂️.
Inside Notable under macOS or Linux this particular graph looks almost ok though (the "o" in "two" is still partially truncated though):
I think this might be an issue related to the font family, as when comparing the SVG rendered in the live editor and inside the app I've noticed a different font family is being used.
So I've explicitly set the same exact font family I'm using in the rest of the app via the following settings object:
And this is the result:
For some reason the fonts that end up being used are different, even though the default ones seem to be inferred from the app anyway, perhaps the logic behind that isn't quite right.
Anyway you can see how pretty much everything gets truncated now for some reason.
Another issue is that using the same font family in the live editor changes nothing, making the live editor useless for testing different font families.
Here there's a more comprehensive corpus of diagrams rendered inside Notable looks like, in case you want to test them yourself, most of them are fine with the default settings under my macOS machine, but under my Windows 10 VM the padding used is absurd:
Result:
When using the custom font family provided above way more texts get truncated:
Bottom line is Mermaid seems to handle font families in a very brittle manner, it should always render properly with a default configuration and it should still work properly when custom font families are set.
Any idea on how I can get it to not truncate texts?
The text was updated successfully, but these errors were encountered: