Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text running out of nodes with larger font size #2139

Open
A-Post opened this issue Jun 18, 2021 · 2 comments
Open

Text running out of nodes with larger font size #2139

A-Post opened this issue Jun 18, 2021 · 2 comments
Assignees
@knsv
Labels
Status: Approved Is ready to be worked on Status: In progress Type: Bug / Error Something isn't working or is incorrect

Comments

@A-Post
Copy link

A-Post commented Jun 18, 2021 •
edited
Loading

Describe the bug
In flowcharts nodes are not growing with the font-size, text is cut by node-borders

To Reproduce
Steps to reproduce the behavior:

  1. Set the font-size to e.g. 20px:
    classDef default font-size:20px;
    grafik

You can reproduce this in live-editor.
Expected behavior
I would expect that nodes growing with larger font-size

Screenshots
mermaid-diagram-20210618075044

Code Sample
live editor.

Desktop (please complete the following information):

  • OS: win10
  • Browser FF/Chrome
  • Version current

Smartphone (please complete the following information):
not used

Additional context
nothing more to say
@A-Post A-Post added Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect labels Jun 18, 2021
@A-Post
Copy link
Author

A-Post commented Jul 23, 2021

Did I something wrong with this issue?

@gphilipp
Copy link

I've done a repro case in live editor

@pineapplemachine pineapplemachine mentioned this issue Jun 28, 2022
Open
@knsv knsv self-assigned this Aug 10, 2023
@knsv knsv added Status: Approved Is ready to be worked on Status: In progress and removed Status: Triage Needs to be verified, categorized, etc labels Aug 10, 2023
knsv added a commit that referenced this issue Aug 11, 2023
@knsv
#2139 Applying user defined classes properly when calculating shape w…
c55a094 
…idth
@knsv knsv mentioned this issue Aug 11, 2023
Merged
4 tasks
knsv added a commit that referenced this issue Aug 11, 2023
@knsv
Merge pull request #4722 from mermaid-js/2139-handling-styling-proper…
9049a99 
…ly-when-calculating-width

#2139 Applying user defined classes properly when calculating shape width
knsv added a commit that referenced this issue Aug 11, 2023
@knsv
Adding new flowchart tests related to issue #2139
c5e7e60
sidharthv96 added a commit that referenced this issue Aug 12, 2023
@sidharthv96
Merge remote-tracking branch 'origin/release/10.3.1'
aa34b99 
* origin/release/10.3.1: (85 commits)
  Version update and adjusted error diagram
  Fix for broker error diagram related #4178
  Adding new flowchart tests related to issue #2139
  Fix for interim issue with classes in state diagrams
  use default export in `error` diagram
  create `ParserDefinition` type
  standardized `error` diagram'
  #2139 Applying user defined classes properly when calculating shape width
  style: format packages/mermaid/src/config.type.ts
  build(types): use prettier conf on config.types.ts
  Syntax Update CONTRIBUTING.md
  docs: Correct detectType filename
  chore: Minor cleanups
  chore: remove comment
  chore: Remove comments, cleanup
  fix!(deps): fix zenuml style leakage. update @zenuml/core to ^3.0.6 to fix the style leakage.
  Update selectSvgElement.ts
  create `Group` type
  Add specialChars in textNoTagsToken, alphaNumToken
  Return Unicode Text to idStringToken definition
  ...
sidharthv96 added a commit that referenced this issue Aug 12, 2023
@sidharthv96
Merge branch 'master' into develop
43217e1 
* master:
  Version update and adjusted error diagram
  Fix for broker error diagram related #4178
  Adding new flowchart tests related to issue #2139
  Fix for interim issue with classes in state diagrams
  #2139 Applying user defined classes properly when calculating shape width
  chore: Ignore localhost
  Update packages/mermaid/src/docs/community/development.md
  Update docs/community/development.md
  docs: Add development example page.
sidharthv96 added a commit that referenced this issue Aug 12, 2023
@sidharthv96
Merge branch 'next' into sidv/esbuildV10
dce65c6 
* next:
  Update assignWithDepth.ts
  Version update and adjusted error diagram
  Fix for broker error diagram related #4178
  Adding new flowchart tests related to issue #2139
  Fix for interim issue with classes in state diagrams
  redeclare `config` parameter add default value for each variable
  convert `assignWithDepth` to TS
  #2139 Applying user defined classes properly when calculating shape width
  chore: Ignore localhost
  Update packages/mermaid/src/docs/community/development.md
  Update docs/community/development.md
  docs: Add development example page.
  docs: Correct detectType filename
  chore: Minor cleanups
  chore: remove comment
  chore: Remove comments, cleanup
  fix: unitTests after tripleParsing removal
  fix: Remove triple parsing of diagrams
sidharthv96 added a commit to sidharthv96/mermaid that referenced this issue Aug 12, 2023
@sidharthv96
Merge branch 'sidv/esbuildV10' into sidv/langiumEsbuild
4e36379 
* sidv/esbuildV10: (38 commits)
  Fix iife test
  Update docs
  Match any function name in error
  Update version
  Add error log with breaking change
  feat: Add IIFE
  Add vite server back
  Cleanup package.json
  Fix package.json
  chore: Refactor build to simplify vite and esbuild
  chore: Refactor build to simplify vite and esbuild
  Fix zenuml
  Version update and adjusted error diagram
  Fix for broker error diagram related mermaid-js#4178
  Adding new flowchart tests related to issue mermaid-js#2139
  Fix for interim issue with classes in state diagrams
  Fix tests
  Add zenuml
  mermaid-js#2139 Applying user defined classes properly when calculating shape width
  chore: Ignore localhost
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@knsv knsv

Labels
Status: Approved Is ready to be worked on Status: In progress Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gphilipp @knsv @A-Post