Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fresh fork: can't build dist #296

Closed
LarryKlugerDS opened this issue Feb 9, 2016 · 4 comments
Closed

Fresh fork: can't build dist #296

LarryKlugerDS opened this issue Feb 9, 2016 · 4 comments

Comments

@LarryKlugerDS
Copy link
Contributor

Hi,
Thank you for the great sw. I did a fresh fork, then:

npm install
java -jar ../local/yuicompressor-2.4.8.jar dist/mermaid.min.js -o foo 
[No errors. (I will be adding the library to other libraries and compressing them all.)]
[No changes to the source tree]
gulp dist
[20:00:43] Using gulpfile ~/www/mermaid/gulpfile.js
[20:00:43] Starting 'mermaidAPI'...
[20:00:43] Starting 'mermaidAPI.slim'...
[20:00:43] Starting 'mermaid.slim'...
[20:00:43] Starting 'mermaid'...
[20:00:47] Finished 'mermaidAPI' after 4.08 s
[20:03:21] Finished 'mermaid' after 2.67 min
[20:03:30] Finished 'mermaidAPI.slim' after 2.82 min
[20:03:30] Finished 'mermaid.slim' after 2.82 min
[20:03:30] Starting 'dist'...
[20:03:30] Finished 'dist' after 6.23 μs
[Now re-run the compressor on the fresh mermaid.min.js. BUT, this time there are errors.
It seems that the source didn't build right.....]
DSA010328:mermaid larry.kluger$ java -jar ../local/yuicompressor-2.4.8.jar dist/mermaid.min.js -o foo
[ERROR] in dist/mermaid.min.js
  12:21587:missing name after . operator
[ERROR] in dist/mermaid.min.js
  15:18311:missing name after . operator
[ERROR] in dist/mermaid.min.js
  15:18452:missing name after . operator
[ERROR] in dist/mermaid.min.js
....

Thank you for any ideas,
Larry

@knsv
Copy link
Collaborator

knsv commented Feb 9, 2016

try running the command:
npm run dist

That might solve the issue. Tried the non gulp/grunt approach but am not totally convinced.

@LarryKlugerDS
Copy link
Contributor Author

Many thanks!
Yes, that worked.

I also found and fixed a code generation bug in src/mermaid.js. See next issue and pull.

@LarryKlugerDS
Copy link
Contributor Author

Do you want me to make documentation change about using npm run dist to build dist?

@knsv
Copy link
Collaborator

knsv commented Feb 10, 2016

Please do, you are on fire :)

mgenereu pushed a commit to mgenereu/mermaid that referenced this issue Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants