Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundling external diagrams #3701

Closed
sidharthv96 opened this issue Oct 20, 2022 · 0 comments · Fixed by #3774
Closed

Bundling external diagrams #3701

sidharthv96 opened this issue Oct 20, 2022 · 0 comments · Fixed by #3774
Labels
Status: Triage Needs to be verified, categorized, etc Type: Enhancement New feature or request

Comments

@sidharthv96
Copy link
Member

Is your feature request related to a problem? Please describe.
With the new lazyLoadedDiagrams, there is the requirement for an extra web request to fetch diagrams.
This might not be feasible in all environments (corporate firewalls, plugin limitations, etc).

Describe the solution you'd like
We should allow an option to pass diagrams directly to mermaid so it can avoid the network call.
This way, external diagrams could be bundled in at build time (if needed), reducing the time to load.

Describe alternatives you've considered
None

Additional context
We could also release versions of mermaid with different diagrams bundled.

@sidharthv96 sidharthv96 added Type: Enhancement New feature or request Status: Triage Needs to be verified, categorized, etc labels Oct 20, 2022
@sidharthv96 sidharthv96 linked a pull request Nov 10, 2022 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Triage Needs to be verified, categorized, etc Type: Enhancement New feature or request
Projects
None yet
1 participant