Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/mermaid9.2.0rc #406

Closed
wants to merge 6 commits into from
Closed

Feature/mermaid9.2.0rc #406

wants to merge 6 commits into from

Conversation

MindaugasLaganeckas
Copy link
Member

@MindaugasLaganeckas MindaugasLaganeckas commented Oct 19, 2022 •
edited
Loading

Testing mindmap in mermaid 9.2.0 rc

MindaugasLaganeckas and others added 3 commits October 19, 2022 09:26
@MindaugasLaganeckas
Remove stupid test
7090cef
@MindaugasLaganeckas
Update lock file
ee6751f
@aloisklink
chore(deps): bump mermaid to v9.2.0-rc8
fbd86cb 
Bumps Mermaid to v9.2.0-rc8 as a preparation for v9.2.0

The tests needed to be modified slightly, since the following
error is now thrown for our invalid mermaid file test:

```
Error: No diagram type detected for text: ...
```
@aloisklink aloisklink mentioned this pull request Oct 20, 2022
Merged
3 tasks
@aloisklink
Copy link
Member

Current Issues

  • mermaid-mindmap is currently loaded from a CDN, which isn't good. This means that mindmaps won't work if there is no internet connection (or if the network blocks CDNs).
    See

    mermaid-cli/src/index.js

    Lines 203 to 206 in af6ded8

    lazyLoadedDiagrams: [
    // TODO: bundle mermaid-mindmap instead of downloading from CDN
    'https://cdn.jsdelivr.net/npm/@mermaid-js/mermaid-mindmap@9.2.0-rc5/dist/mermaid-mindmap-detector.esm.mjs'
    ],

    Ideally, we'd want to somehow bundle mermaid-mindmap, but due to puppeteer CSP issues, that will probably need to wait until Bundling external diagrams mermaid#3701 is fixed.

  • mermaid won't load mermaid-mindmap using mermaid.initThrowsErrors until PR Support lazyLoadedDiagrams when calling initThrowsErrors mermaid#3702 is merged and released

@aloisklink aloisklink force-pushed the feature/mermaid9.2.0rc branch from af6ded8 to 81ca73a Compare October 20, 2022 11:37
@aloisklink
fix: add mermaid-mindmap support
bbb0eeb 
Adds and tests basic support for mermaid-mindmaps.

Issues
======

- mermaid-mindmap is currently loaded from a CDN, which isn't good.
  This means that mindmaps won't work if there is no internet
  connection (or if the network blocks CDNs).
- We have to use pin to 9.2.0-rc10, since `9.2.0-rc9` is higher than
  `^9.2.0-rc10` in semver (alphabetical sort)
@aloisklink aloisklink force-pushed the feature/mermaid9.2.0rc branch from 81ca73a to bbb0eeb Compare October 28, 2022 20:00
@aloisklink aloisklink mentioned this pull request Nov 6, 2022
Closed
3 tasks
@MindaugasLaganeckas
Copy link
Member Author

Closed in favor of #420

@aloisklink aloisklink deleted the feature/mermaid9.2.0rc branch March 29, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MindaugasLaganeckas @aloisklink