-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hash "#" symbol as prefix is not working for sequenceDiagram #5419
Labels
Status: Triage
Needs to be verified, categorized, etc
Type: Bug / Error
Something isn't working or is incorrect
Comments
dav1tj
added
Status: Triage
Needs to be verified, categorized, etc
Type: Bug / Error
Something isn't working or is incorrect
labels
Mar 27, 2024
Hi @dav1tj, I think I know you from somewhere else ;) These two PRs are related, major concern is breaking existing diagrams, so if that won't be an issue, we can have this.
Having # at the start of an id seems a bit odd(as it's usually not used, or used as a modifier in coding), what's the use case? |
fedarko
added a commit
to fedarko/strainFlye
that referenced
this issue
Sep 16, 2024
one more thing i forgot to mention in the previous commit -- using "#" in the node name for "# mutations / Mb" caused the node label to vanish, presumably because of mermaid-js/mermaid#5419. the previous commit fixed this (changing "# mutations" to "Number of mutations"), but this made the node label a bit too wide (not wide enough to trigger the other bug documented in the previous commit, but still wide enough to look a bit off). so anyway this commit adds another <br/> to make the nodes all have roughly the same size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Status: Triage
Needs to be verified, categorized, etc
Type: Bug / Error
Something isn't working or is incorrect
Description
When we are using "#" has symbol as prefix in sequence diagram, text becomes empty.
Steps to reproduce
Try to use this code:
sequenceDiagram
actor Alice as #1
actor Bob as Bob
actor actor_sgautk7mz as New Actor
Note over Bob: #55
Bob -->> Bob: new msg
Alice ->> Bob: #66
Bob ->> Alice: Hi Alice
Screenshots
Code Sample
No response
Setup
Suggested Solutions
No response
Additional Context
No response
The text was updated successfully, but these errors were encountered: