Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cap-cased words break parser #8

Closed
hlfcoding opened this issue Dec 1, 2014 · 6 comments
Closed

Cap-cased words break parser #8

hlfcoding opened this issue Dec 1, 2014 · 6 comments
Assignees
Labels
Type: Bug / Error Something isn't working or is incorrect

Comments

@hlfcoding
Copy link

Uncaught Error: Parse error on line 6:
... A-->|Link text|B[Some URL];    C-->D[Some text
---------------------------^
Expecting 'SPACE', 'SQE', 'PE', 'DIAMOND_STOP', 'TAGEND', 'TAGSTART', 'MINUS', 'ALPHA', 'NUM', 'COLON', 'COMMA', 'PLUS', 'EQUALS', 'MULT', 'DOT', 'BRKT', 'PIPE', got 'DIR'
mermaid.full.min.js:34 X.parseError
mermaid.full.min.js:34 X.parse
mermaid.full.min.js:34 p
mermaid.full.min.js:34 h
mermaid.full.min.js:34 (anonymous function)
@knsv
Copy link
Collaborator

knsv commented Dec 1, 2014

Seems the word URL contains the lexical element RL as in the direction right to left. Will think a bit on this. Maybe the direction statements need to be be a little more specific.

@knsv
Copy link
Collaborator

knsv commented Dec 1, 2014

Will change the syntax for directions to something like DIR. Will do it in connection with a somewhat bigger change as break backwards compatibility.

@knsv knsv added the Type: Bug / Error Something isn't working or is incorrect label Dec 1, 2014
@knsv
Copy link
Collaborator

knsv commented Dec 2, 2014

After a night sleep I found the obvious solution where the syntax need not to be changed. Only need to include a set of keywords as like DIR as valid text tokens in the grammar. Fix will come.

@knsv knsv self-assigned this Dec 2, 2014
@knsv
Copy link
Collaborator

knsv commented Dec 3, 2014

Fixed in head, will come in next release.

@hlfcoding
Copy link
Author

👏

@knsv
Copy link
Collaborator

knsv commented Dec 3, 2014

Fixed in 0.2.14

@knsv knsv closed this as completed Dec 3, 2014
knsv pushed a commit that referenced this issue Jan 2, 2020
knsv pushed a commit that referenced this issue Aug 4, 2021
Bumps [terser-webpack-plugin](https://github.com/webpack-contrib/terser-webpack-plugin) from 2.3.8 to 4.2.3.
- [Release notes](https://github.com/webpack-contrib/terser-webpack-plugin/releases)
- [Changelog](https://github.com/webpack-contrib/terser-webpack-plugin/blob/master/CHANGELOG.md)
- [Commits](webpack-contrib/terser-webpack-plugin@v2.3.8...v4.2.3)

---
updated-dependencies:
- dependency-name: terser-webpack-plugin
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Development

No branches or pull requests

2 participants