Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Split flow.spec.js into several files #906

Closed
knsv opened this issue Aug 8, 2019 · 2 comments
Closed

chore: Split flow.spec.js into several files #906

knsv opened this issue Aug 8, 2019 · 2 comments
Assignees
@christopherkade
Labels
Area: Development Graph: Flow Status: Approved Is ready to be worked on Type: Enhancement New feature or request

Comments

@knsv
Copy link
Collaborator

knsv commented Aug 8, 2019

The file has grown to large and needs to be split into several files
@PatrickRoumanoff
Copy link

There are 156 test in the spec file, would splitting the files according to those categories be a good fit?

category count
arrow 22
comment 9
edge 32
flow (default) 10
interaction 4
line 12
singlenode 13
style 19
subgraph 8
text 27
total 156

@IOrlandoni IOrlandoni added Area: Development Status: Approved Is ready to be worked on Type: Enhancement New feature or request and removed Type: Chore labels Sep 24, 2019
@christopherkade
Copy link
Contributor

Hi @knsv, if this issue is still up for grabs, I'd love to help out, I could use Patrick's input to divide the file.

christopherkade added a commit to christopherkade/mermaid that referenced this issue Oct 14, 2019
@christopherkade
mermaid-js#906 Divided flow unit tests
89b6ccf
@christopherkade christopherkade mentioned this issue Oct 14, 2019
Merged
knsv added a commit that referenced this issue Oct 15, 2019
@knsv
Merge pull request #991 from christopherkade/feature/divided-flow-tests
b881e5c 
#906 Divided flow unit tests
@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@christopherkade christopherkade

Labels
Area: Development Graph: Flow Status: Approved Is ready to be worked on Type: Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@PatrickRoumanoff @IOrlandoni @knsv @christopherkade