Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/Multiline sequence message #1314

Merged
merged 1 commit into from
Mar 25, 2020
Merged

Feature/Multiline sequence message #1314

merged 1 commit into from
Mar 25, 2020

Conversation

rmedaer
Copy link
Contributor

@rmedaer rmedaer commented Mar 24, 2020

📑 Summary

This commit allow user to write multiline messages in sequence diagram.
For instance:

sequenceDiagram
	Alice->>+John: Hello John<br>How are you?<br>I mean...<br>Are you OK today?
	Alice->>+John: John, can you hear me?
	John-->>-Alice: Hi Alice, I can hear you!<br>Keep calm!<br>I'm there.
	John-->>-Alice: And I feel great!

📏 Design Decisions

Bump vertical position according to number of lines. Idem for the arrow/line.

Here is a demo:
example

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added unit/e2e tests (if appropriate)
  • 🔖 targeted develop branch

@rmedaer
Multiline sequence message
d409da2 
This commit allow user to write multiline messages in sequence diagram.
For instance:

```
sequenceDiagram
	Alice->>+John: Hello John<br>How are you?<br>I mean...<br>Are you OK today?
	Alice->>+John: John, can you hear me?
	John-->>-Alice: Hi Alice, I can hear you!<br>Keep calm!<br>I'm there.
	John-->>-Alice: And I feel great!
```
@rmedaer rmedaer changed the title Multiline sequence message Feature/Multiline sequence message Mar 24, 2020
@rmedaer rmedaer mentioned this pull request Mar 24, 2020
Merged
3 tasks
@rmedaer
Copy link
Contributor Author

rmedaer commented Mar 24, 2020

It seems there is an issue with pr-labeler action: see TimonVS/pr-labeler-action/issue/25

Btw, build and tests are still working !

@IOrlandoni IOrlandoni requested a review from knsv March 25, 2020 12:31
@knsv
Copy link
Collaborator

knsv commented Mar 25, 2020

Yes, we should fix that thing. Sorry if it git you on alert. :)

knsv
knsv reviewed Mar 25, 2020
View reviewed changes
Copy link
Collaborator

@knsv knsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@knsv knsv merged commit 9e75993 into mermaid-js:develop Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knsv knsv knsv left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rmedaer @knsv