Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ability to overlap notes and messages #2746

Closed

Conversation

twpol
Copy link

@twpol twpol commented Feb 18, 2022

📑 Summary

Add ability to overlap (in time) notes and messages in a sequence diagram with new directive par_over

Resolves #2087

📏 Design Decisions

  • This new directive works the same as par except: each message or note inside is positioned with the same top position
  • The code currently only checks for the innermost loop being par_over, since it is not immediately clear what should happen in other cases
  • Because the messages and notes are always vertical aligned to the top, messages with a variable number of lines of text aren't lined up

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added unit/e2e tests (if appropriate)
  • 🔖 targeted develop branch

@jgreywolf
Copy link
Contributor

@twpol Any updates?

@twpol
Copy link
Author

twpol commented Jan 26, 2023

@twpol Any updates?

Unfortunately, the 11 months of no engagement has left this with a load of conflicts, and I have long-since moved on

I might be persuaded to resolve the conflicts, but I am unlikely to be willing to make anything more than cosmetic changes for reviews at this point in time

@jgreywolf jgreywolf mentioned this pull request May 4, 2023
4 tasks
@Yokozuna59
Copy link
Member

Since it has been implemented in #4370, I guess we should close this, am I right @jgreywolf?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SequenceDiagram: floating notes / notes on the same line
3 participants