Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 299: Sequence diagram Loops: changing boxMargin spoils the "loop" notation #300

Merged
merged 3 commits into from
Feb 10, 2016
Merged

Issue 299: Sequence diagram Loops: changing boxMargin spoils the "loop" notation #300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
31f78d1
Issue 299: Sequence diagram Loops: changing boxMargin spoils the "loo…
LarryKlugerDS Feb 10, 2016
eef6eb9
Issue #296 -- better build instructions
LarryKlugerDS Feb 10, 2016
0f7dda9
#296 Further edit of build instructions
LarryKlugerDS Feb 10, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,20 +53,24 @@ Fork, then:
npm install
```

Then the dependencies will have been installed. You use gulp as build tool.
Then the dependencies will have been installed. You use gulp and npm calls as build tools.

The following targets are probably interesting:

* jison - compiles the jison grammars to parser files
* dist - complies files to the dist catalog

for instance:
```
gulp jasmine
gulp jison
```
To run the tests:
```
npm run karma
```

To build the /dist directory
```
npm run dist
```

Thanks, Knut Sveidqvist
4 changes: 2 additions & 2 deletions src/diagrams/sequenceDiagram/svgDraw.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,8 @@ exports.drawLoop = function(elem,bounds,labelText, conf){
txt.text = labelText;
txt.x = bounds.startx;
txt.y = bounds.starty;
txt.labelMargin = 1.5 * conf.boxMargin;
txt.class = 'labelText';
txt.labelMargin = 1.5 * 10; // This is the small box that says "loop"
txt.class = 'labelText'; // Its size & position are fixed.
txt.fill = 'white';

exports.drawLabel(g,txt);
Expand Down