Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defects/issue 3878 #3880

Merged
merged 3 commits into from
Dec 6, 2022
Merged

Conversation

MrCoder
Copy link
Contributor

@MrCoder MrCoder commented Dec 3, 2022

📑 Summary

Fixed the issue the diagrams disappear or theme does not switch on docs pages.

Resolves #3878

📏 Design Decisions

  1. Clone the config and avoid mutating the original shared config;
  2. Add salt to the svg code before rendering on the docs pages.

For #2, there are other ways to force the vue component (Mermaid) to update, such as this and this. Adding salt is most simple to undo and low chance to have other side effect.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added unit/e2e tests (if appropriate) (No test added)
  • 🔖 targeted develop branch

Comment on lines 11 to 13
// make a clone of config, so we don't mutate the original
const mermaidConfig = { ...config };
mermaid.initialize(mermaidConfig);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we handle this inside mermaid, and do a proper clone if it's a problem?
Where is this mutated at?
{...config} will only ensure that the top-level configs aren't changed, nested configs will still be mutated.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried moving mermaidConfig inside the render function, so no global state is maintained.

---
 .../mermaid/src/docs/.vitepress/theme/Mermaid.vue | 15 ++++++---------
 .../mermaid/src/docs/.vitepress/theme/mermaid.ts  |  4 +---
 2 files changed, 7 insertions(+), 12 deletions(-)

diff --git a/packages/mermaid/src/docs/.vitepress/theme/Mermaid.vue b/packages/mermaid/src/docs/.vitepress/theme/Mermaid.vue
index c9914160..f0927d2a 100644
--- a/packages/mermaid/src/docs/.vitepress/theme/Mermaid.vue
+++ b/packages/mermaid/src/docs/.vitepress/theme/Mermaid.vue
@@ -20,11 +20,6 @@ const props = defineProps({
 const svg = ref(null);
 let mut = null;
 
-const mermaidConfig = {
-  securityLevel: 'loose',
-  startOnLoad: false,
-};
-
 onMounted(async () => {
   mut = new MutationObserver(() => renderChart());
   mut.observe(document.documentElement, { attributes: true });
@@ -56,11 +51,13 @@ onMounted(async () => {
 onUnmounted(() => mut.disconnect());
 
 const renderChart = async () => {
-  console.log('rendering chart' + props.id + props.graph);
+  // console.log('rendering chart' + props.id + props.graph);
   const hasDarkClass = document.documentElement.classList.contains('dark');
-  mermaidConfig.theme = hasDarkClass ? 'dark' : 'default';
-
-  console.log({ mermaidConfig });
+  const mermaidConfig = {
+    securityLevel: 'loose',
+    startOnLoad: false,
+    theme: hasDarkClass ? 'dark' : 'default',
+  };
   let svgCode = await render(props.id, decodeURIComponent(props.graph), mermaidConfig);
   // This is a hack to force v-html to re-render, otherwise the diagram disappears
   // when **switching themes** or **reloading the page**.
diff --git a/packages/mermaid/src/docs/.vitepress/theme/mermaid.ts b/packages/mermaid/src/docs/.vitepress/theme/mermaid.ts
index fef090ea..b287346f 100644
--- a/packages/mermaid/src/docs/.vitepress/theme/mermaid.ts
+++ b/packages/mermaid/src/docs/.vitepress/theme/mermaid.ts
@@ -8,9 +8,7 @@ try {
 }
 
 export const render = async (id: string, code: string, config: MermaidConfig): Promise<string> => {
-  // make a clone of config, so we don't mutate the original
-  const mermaidConfig = { ...config };
-  mermaid.initialize(mermaidConfig);
+  mermaid.initialize(config);
   const svg = await mermaid.renderAsync(id, code);
   return svg;
 };
-- 

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks better than my solution.

@sidharthv96 sidharthv96 merged commit f2ee20f into mermaid-js:develop Dec 6, 2022
@sidharthv96
Copy link
Member

Thanks for the quick fix @MrCoder :)

fuxingloh referenced this pull request in fuxingloh/contented Dec 19, 2022
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [mermaid](https://togithub.com/mermaid-js/mermaid) | [`9.2.2` ->
`9.3.0`](https://renovatebot.com/diffs/npm/mermaid/9.2.2/9.3.0) |
[![age](https://badges.renovateapi.com/packages/npm/mermaid/9.3.0/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/mermaid/9.3.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/mermaid/9.3.0/compatibility-slim/9.2.2)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/mermaid/9.3.0/confidence-slim/9.2.2)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>mermaid-js/mermaid</summary>

###
[`v9.3.0`](https://togithub.com/mermaid-js/mermaid/releases/tag/v9.3.0)

[Compare
Source](https://togithub.com/mermaid-js/mermaid/compare/v9.2.2...v9.3.0)

### Significant Changes

-   25% Smaller
-   New docs
-   Replaces the deprecated and vulnerable `dagre-d3` with `dagre-es`

### Release Notes

- [#&#8203;3778](https://togithub.com/mermaid-js/mermaid/issues/3778)
Adding a hexgon shape
([#&#8203;3834](https://togithub.com/mermaid-js/mermaid/issues/3834))
[@&#8203;knsv](https://togithub.com/knsv)
- [#&#8203;3831](https://togithub.com/mermaid-js/mermaid/issues/3831)
Re-enabling themes for er diagrams
([#&#8203;3837](https://togithub.com/mermaid-js/mermaid/issues/3837))
[@&#8203;knsv](https://togithub.com/knsv)
- [#&#8203;3882](https://togithub.com/mermaid-js/mermaid/issues/3882)
fix for issues with mindmaps with only a single node
([#&#8203;3833](https://togithub.com/mermaid-js/mermaid/issues/3833))
[@&#8203;knsv](https://togithub.com/knsv)
- (chore) remove console stmt in pieDetector
([#&#8203;3840](https://togithub.com/mermaid-js/mermaid/issues/3840))
[@&#8203;weedySeaDragon](https://togithub.com/weedySeaDragon)
- (feat) state classDef documentation
([#&#8203;3841](https://togithub.com/mermaid-js/mermaid/issues/3841))
[@&#8203;weedySeaDragon](https://togithub.com/weedySeaDragon)
- 3882 edge labels
([#&#8203;3883](https://togithub.com/mermaid-js/mermaid/issues/3883))
[@&#8203;knsv](https://togithub.com/knsv)
- Add GHA that will check links + Fix broken links
([#&#8203;3765](https://togithub.com/mermaid-js/mermaid/issues/3765))
[@&#8203;spier](https://togithub.com/spier)
- Add official vim plugin to list in integrations
([#&#8203;3847](https://togithub.com/mermaid-js/mermaid/issues/3847))
[@&#8203;craigmac](https://togithub.com/craigmac)
- Add package visualizations
([#&#8203;3823](https://togithub.com/mermaid-js/mermaid/issues/3823))
[@&#8203;sidharthv96](https://togithub.com/sidharthv96)
- Add support for [@&#8203;include](https://togithub.com/include) in
docs
([#&#8203;3863](https://togithub.com/mermaid-js/mermaid/issues/3863))
[@&#8203;sidharthv96](https://togithub.com/sidharthv96)
- CI: disable pinning dependencies
([#&#8203;3735](https://togithub.com/mermaid-js/mermaid/issues/3735))
[@&#8203;aloisklink](https://togithub.com/aloisklink)
- Defects/issue 3878
([#&#8203;3880](https://togithub.com/mermaid-js/mermaid/issues/3880))
[@&#8203;MrCoder](https://togithub.com/MrCoder)
- Feat: Add aria-describedby, aria-roledescription
([#&#8203;3808](https://togithub.com/mermaid-js/mermaid/issues/3808))
[@&#8203;weedySeaDragon](https://togithub.com/weedySeaDragon)
- Fix
[#&#8203;3799](https://togithub.com/mermaid-js/mermaid/issues/3799):
Remove `type` from package.json
([#&#8203;3802](https://togithub.com/mermaid-js/mermaid/issues/3802))
[@&#8203;sidharthv96](https://togithub.com/sidharthv96)
- Fix for
[#&#8203;3835](https://togithub.com/mermaid-js/mermaid/issues/3835),
makes it possible to style path elements
([#&#8203;3836](https://togithub.com/mermaid-js/mermaid/issues/3836))
[@&#8203;knsv](https://togithub.com/knsv)
- Fix typos
([#&#8203;3820](https://togithub.com/mermaid-js/mermaid/issues/3820))
[@&#8203;endolith](https://togithub.com/endolith)
- Housekeeping with eslint-unicorn
([#&#8203;3845](https://togithub.com/mermaid-js/mermaid/issues/3845))
[@&#8203;sidharthv96](https://togithub.com/sidharthv96)
- Integrations added - Visual Studio Code \[Polyglot Interactive
Notebooks]
([#&#8203;3821](https://togithub.com/mermaid-js/mermaid/issues/3821))
[@&#8203;dfinke](https://togithub.com/dfinke)
- Mindmap integration docs
([#&#8203;3810](https://togithub.com/mermaid-js/mermaid/issues/3810))
[@&#8203;sidharthv96](https://togithub.com/sidharthv96)
- Reduce mermaid size by 31%
([#&#8203;3825](https://togithub.com/mermaid-js/mermaid/issues/3825))
[@&#8203;sidharthv96](https://togithub.com/sidharthv96)
- Remove extra arrow and adjust cross position
([#&#8203;3641](https://togithub.com/mermaid-js/mermaid/issues/3641))
[@&#8203;ishuen](https://togithub.com/ishuen)
- Replace `dagre`/`dagre-d3` with `dagre-d3-es`
([#&#8203;3809](https://togithub.com/mermaid-js/mermaid/issues/3809))
[@&#8203;aloisklink](https://togithub.com/aloisklink)
- Revert "Added pie"
([#&#8203;3842](https://togithub.com/mermaid-js/mermaid/issues/3842))
[@&#8203;pbrolin47](https://togithub.com/pbrolin47)
- Switch CDN to unpkg.com
([#&#8203;3777](https://togithub.com/mermaid-js/mermaid/issues/3777))
[@&#8203;sidharthv96](https://togithub.com/sidharthv96)
- Switch back to jsdelivr
([#&#8203;3873](https://togithub.com/mermaid-js/mermaid/issues/3873))
[@&#8203;sidharthv96](https://togithub.com/sidharthv96)
- Use `github-dark` to highlight fence blocks in vitepress docs
([#&#8203;3807](https://togithub.com/mermaid-js/mermaid/issues/3807))
[@&#8203;aloisklink](https://togithub.com/aloisklink)
- Use current mermaid version in docs.
([#&#8203;3846](https://togithub.com/mermaid-js/mermaid/issues/3846))
[@&#8203;sidharthv96](https://togithub.com/sidharthv96)
- Use stylis to prepend idSelector
([#&#8203;3829](https://togithub.com/mermaid-js/mermaid/issues/3829))
[@&#8203;DanInProgress](https://togithub.com/DanInProgress)
- bug: State diagram fix classes type
([#&#8203;3798](https://togithub.com/mermaid-js/mermaid/issues/3798))
[@&#8203;weedySeaDragon](https://togithub.com/weedySeaDragon)
- bug: change shiki getHighlighter import
([#&#8203;3804](https://togithub.com/mermaid-js/mermaid/issues/3804))
[@&#8203;weedySeaDragon](https://togithub.com/weedySeaDragon)
- chore(deps): remove dependency on `graphlib`
([#&#8203;3861](https://togithub.com/mermaid-js/mermaid/issues/3861))
[@&#8203;aloisklink](https://togithub.com/aloisklink)
- chore(deps): update all non-major dependencies (minor)
([#&#8203;3905](https://togithub.com/mermaid-js/mermaid/issues/3905))
[@&#8203;renovate](https://togithub.com/renovate)
- chore(deps): update all non-major dependencies (minor)
([#&#8203;3791](https://togithub.com/mermaid-js/mermaid/issues/3791))
[@&#8203;renovate](https://togithub.com/renovate)
- chore(deps): update lycheeverse/lychee-action action to v1.5.4
([#&#8203;3827](https://togithub.com/mermaid-js/mermaid/issues/3827))
[@&#8203;renovate](https://togithub.com/renovate)
- chore(deps): update pnpm to v7.17.0
([#&#8203;3828](https://togithub.com/mermaid-js/mermaid/issues/3828))
[@&#8203;renovate](https://togithub.com/renovate)
- chore(deps): update pnpm to v7.17.1
([#&#8203;3862](https://togithub.com/mermaid-js/mermaid/issues/3862))
[@&#8203;renovate](https://togithub.com/renovate)
- chore(docs): Auto build docs
([#&#8203;3547](https://togithub.com/mermaid-js/mermaid/issues/3547))
[@&#8203;sidharthv96](https://togithub.com/sidharthv96)
- chore: Housekeeping
([#&#8203;3783](https://togithub.com/mermaid-js/mermaid/issues/3783))
[@&#8203;sidharthv96](https://togithub.com/sidharthv96)
- chore: Merge master to develop
([#&#8203;3780](https://togithub.com/mermaid-js/mermaid/issues/3780))
[@&#8203;sidharthv96](https://togithub.com/sidharthv96)
- chore: clean up code in mermaidAPI render() and write specs/tests
([#&#8203;3684](https://togithub.com/mermaid-js/mermaid/issues/3684))
[@&#8203;weedySeaDragon](https://togithub.com/weedySeaDragon)
- chore: delete functions not used in diagrams/c4 code (dead code)
([#&#8203;3871](https://togithub.com/mermaid-js/mermaid/issues/3871))
[@&#8203;weedySeaDragon](https://togithub.com/weedySeaDragon)
- comments in states are skipped now
([#&#8203;3762](https://togithub.com/mermaid-js/mermaid/issues/3762))
[@&#8203;avijit1258](https://togithub.com/avijit1258)
- doc: remove links from atom.io; add note Atom has been archived
([#&#8203;3899](https://togithub.com/mermaid-js/mermaid/issues/3899))
[@&#8203;weedySeaDragon](https://togithub.com/weedySeaDragon)
- docs: refactor Theming doc
([#&#8203;3889](https://togithub.com/mermaid-js/mermaid/issues/3889))
[@&#8203;huynhicode](https://togithub.com/huynhicode)
- feat: Redirect old documentation links.
([#&#8203;3797](https://togithub.com/mermaid-js/mermaid/issues/3797))
[@&#8203;sidharthv96](https://togithub.com/sidharthv96)
- feat: Title support via front matter for ER, state, class, git, and
graph diagrams
([#&#8203;3706](https://togithub.com/mermaid-js/mermaid/issues/3706))
[@&#8203;MasonM](https://togithub.com/MasonM)
- fix(deps): update all non-major dependencies (patch)
([#&#8203;3790](https://togithub.com/mermaid-js/mermaid/issues/3790))
[@&#8203;renovate](https://togithub.com/renovate)
- fix(deps): update dependency rollup to v3
([#&#8203;3674](https://togithub.com/mermaid-js/mermaid/issues/3674))
[@&#8203;renovate](https://togithub.com/renovate)
- fix: LintStaged
([#&#8203;3844](https://togithub.com/mermaid-js/mermaid/issues/3844))
[@&#8203;sidharthv96](https://togithub.com/sidharthv96)

🎉 **Thanks to all contributors helping with this release!** 🎉

#### What's Changed

- chore(deps): update actions/checkout action to v3 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/mermaid-js/mermaid/pull/3645](https://togithub.com/mermaid-js/mermaid/pull/3645)
- chore(deps): update actions/setup-node action to v3 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/mermaid-js/mermaid/pull/3646](https://togithub.com/mermaid-js/mermaid/pull/3646)
- Remove inconsistent and deprecated semicolons by
[@&#8203;revolter](https://togithub.com/revolter) in
[https://github.com/mermaid-js/mermaid/pull/3657](https://togithub.com/mermaid-js/mermaid/pull/3657)
- Fix windows paths for `docs:build` by
[@&#8203;arpansaha13](https://togithub.com/arpansaha13) in
[https://github.com/mermaid-js/mermaid/pull/3605](https://togithub.com/mermaid-js/mermaid/pull/3605)
- feat: make `parseError` function more type-safe by
[@&#8203;Some-Dood](https://togithub.com/Some-Dood) in
[https://github.com/mermaid-js/mermaid/pull/3643](https://togithub.com/mermaid-js/mermaid/pull/3643)
- chore(deps): update all non-major dependencies (minor) by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/mermaid-js/mermaid/pull/3632](https://togithub.com/mermaid-js/mermaid/pull/3632)
- chore(deps): update all non-major dependencies (patch) by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/mermaid-js/mermaid/pull/3671](https://togithub.com/mermaid-js/mermaid/pull/3671)
- chore(deps): pin dependencies by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/mermaid-js/mermaid/pull/3685](https://togithub.com/mermaid-js/mermaid/pull/3685)
- Added Open Graph meta tags by
[@&#8203;danangtomo](https://togithub.com/danangtomo) in
[https://github.com/mermaid-js/mermaid/pull/3679](https://togithub.com/mermaid-js/mermaid/pull/3679)
- add eslint-plugin-no-only-tests plugin by
[@&#8203;DKurilo](https://togithub.com/DKurilo) in
[https://github.com/mermaid-js/mermaid/pull/3690](https://togithub.com/mermaid-js/mermaid/pull/3690)
- Added and configured cspell plugin to eslint by
[@&#8203;devcer](https://togithub.com/devcer) in
[https://github.com/mermaid-js/mermaid/pull/3604](https://togithub.com/mermaid-js/mermaid/pull/3604)
- fix: gantt demo diagrams
([#&#8203;3655](https://togithub.com/mermaid-js/mermaid/issues/3655)) by
[@&#8203;isinek](https://togithub.com/isinek) in
[https://github.com/mermaid-js/mermaid/pull/3688](https://togithub.com/mermaid-js/mermaid/pull/3688)
- Chore/3697 eslint curly by
[@&#8203;jeroenekkelkamp](https://togithub.com/jeroenekkelkamp) in
[https://github.com/mermaid-js/mermaid/pull/3698](https://togithub.com/mermaid-js/mermaid/pull/3698)
- Update sequenceDiagram.md by
[@&#8203;imgss](https://togithub.com/imgss) in
[https://github.com/mermaid-js/mermaid/pull/3707](https://togithub.com/mermaid-js/mermaid/pull/3707)
- Use `eslint-plugin-tsdoc` for TypeScript files instead of
`eslint-plugin-jsdoc` by
[@&#8203;aloisklink](https://togithub.com/aloisklink) in
[https://github.com/mermaid-js/mermaid/pull/3708](https://togithub.com/mermaid-js/mermaid/pull/3708)
- chore(deps): pin dependencies by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/mermaid-js/mermaid/pull/3713](https://togithub.com/mermaid-js/mermaid/pull/3713)
- chore(deps): update all non-major dependencies (patch) by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/mermaid-js/mermaid/pull/3714](https://togithub.com/mermaid-js/mermaid/pull/3714)
- Order pie chart slices clockwise by order of entries by
[@&#8203;jasmaa](https://togithub.com/jasmaa) in
[https://github.com/mermaid-js/mermaid/pull/3609](https://togithub.com/mermaid-js/mermaid/pull/3609)
- fix: border attribute does not work in a certain writing style by
[@&#8203;maiermic](https://togithub.com/maiermic) in
[https://github.com/mermaid-js/mermaid/pull/3636](https://togithub.com/mermaid-js/mermaid/pull/3636)
- add the way to add notes to class diagram by
[@&#8203;DKurilo](https://togithub.com/DKurilo) in
[https://github.com/mermaid-js/mermaid/pull/3647](https://togithub.com/mermaid-js/mermaid/pull/3647)
- add statement aliases for ER diagram by
[@&#8203;DKurilo](https://togithub.com/DKurilo) in
[https://github.com/mermaid-js/mermaid/pull/3649](https://togithub.com/mermaid-js/mermaid/pull/3649)
- fix: Fix useMaxWidth option for git graph by
[@&#8203;uttk](https://togithub.com/uttk) in
[https://github.com/mermaid-js/mermaid/pull/3652](https://togithub.com/mermaid-js/mermaid/pull/3652)
- [#&#8203;3659](https://togithub.com/mermaid-js/mermaid/issues/3659)
Adding height when not using maxWidth by
[@&#8203;knsv](https://togithub.com/knsv) in
[https://github.com/mermaid-js/mermaid/pull/3668](https://togithub.com/mermaid-js/mermaid/pull/3668)
- Change fill attribute to style by
[@&#8203;CalebUsadi](https://togithub.com/CalebUsadi) in
[https://github.com/mermaid-js/mermaid/pull/3719](https://togithub.com/mermaid-js/mermaid/pull/3719)
- feat: \[State diagram] Add classDefs and classes to states by
[@&#8203;weedySeaDragon](https://togithub.com/weedySeaDragon) in
[https://github.com/mermaid-js/mermaid/pull/3644](https://togithub.com/mermaid-js/mermaid/pull/3644)
- Fill inheritance arrow with background color by
[@&#8203;vallsv](https://togithub.com/vallsv) in
[https://github.com/mermaid-js/mermaid/pull/3543](https://togithub.com/mermaid-js/mermaid/pull/3543)
- Ensure example code and rendered output are synced by
[@&#8203;marcjansen](https://togithub.com/marcjansen) in
[https://github.com/mermaid-js/mermaid/pull/3721](https://togithub.com/mermaid-js/mermaid/pull/3721)
- fix(git): Support quoted branch names by
[@&#8203;gibson042](https://togithub.com/gibson042) in
[https://github.com/mermaid-js/mermaid/pull/3726](https://togithub.com/mermaid-js/mermaid/pull/3726)
- docs: Add link to docs source by
[@&#8203;sidharthv96](https://togithub.com/sidharthv96) in
[https://github.com/mermaid-js/mermaid/pull/3612](https://togithub.com/mermaid-js/mermaid/pull/3612)
- chore(deps): update all non-major dependencies (patch) by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/mermaid-js/mermaid/pull/3736](https://togithub.com/mermaid-js/mermaid/pull/3736)
- chore(deps): update all non-major dependencies (minor) by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/mermaid-js/mermaid/pull/3737](https://togithub.com/mermaid-js/mermaid/pull/3737)
- feat(gantt): Add option 'tickInterval' for custom tick interval by
[@&#8203;DarkNami](https://togithub.com/DarkNami) in
[https://github.com/mermaid-js/mermaid/pull/3729](https://togithub.com/mermaid-js/mermaid/pull/3729)
- Fix/convert attr to style in er graph by
[@&#8203;CalebUsadi](https://togithub.com/CalebUsadi) in
[https://github.com/mermaid-js/mermaid/pull/3722](https://togithub.com/mermaid-js/mermaid/pull/3722)
- update user story link for
[#&#8203;3740](https://togithub.com/mermaid-js/mermaid/issues/3740) by
[@&#8203;6footGeek](https://togithub.com/6footGeek) in
[https://github.com/mermaid-js/mermaid/pull/3741](https://togithub.com/mermaid-js/mermaid/pull/3741)
- Improved New Documentation by
[@&#8203;emersonbottero](https://togithub.com/emersonbottero) in
[https://github.com/mermaid-js/mermaid/pull/3678](https://togithub.com/mermaid-js/mermaid/pull/3678)
- chore: fix cSpell word entry misspelling "mermiad" -> "mermaid" by
[@&#8203;weedySeaDragon](https://togithub.com/weedySeaDragon) in
[https://github.com/mermaid-js/mermaid/pull/3751](https://togithub.com/mermaid-js/mermaid/pull/3751)
- Fix link to CSS classes by
[@&#8203;hugovk](https://togithub.com/hugovk) in
[https://github.com/mermaid-js/mermaid/pull/3752](https://togithub.com/mermaid-js/mermaid/pull/3752)
- docs: Update references to default config in directives page by
[@&#8203;raptor0929](https://togithub.com/raptor0929) in
[https://github.com/mermaid-js/mermaid/pull/3738](https://togithub.com/mermaid-js/mermaid/pull/3738)
- Fix link relative links to documentation files by
[@&#8203;spier](https://togithub.com/spier) in
[https://github.com/mermaid-js/mermaid/pull/3760](https://togithub.com/mermaid-js/mermaid/pull/3760)
- chore(deps): update all non-major dependencies (patch) by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/mermaid-js/mermaid/pull/3769](https://togithub.com/mermaid-js/mermaid/pull/3769)
- chore(deps): update all non-major dependencies (minor) by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/mermaid-js/mermaid/pull/3770](https://togithub.com/mermaid-js/mermaid/pull/3770)
- Fix CSpell by [@&#8203;sidharthv96](https://togithub.com/sidharthv96)
in
[https://github.com/mermaid-js/mermaid/pull/3753](https://togithub.com/mermaid-js/mermaid/pull/3753)
- Live edits for Docs by
[@&#8203;sidharthv96](https://togithub.com/sidharthv96) in
[https://github.com/mermaid-js/mermaid/pull/3755](https://togithub.com/mermaid-js/mermaid/pull/3755)
- Switch CDN to unpkg.com by
[@&#8203;sidharthv96](https://togithub.com/sidharthv96) in
[https://github.com/mermaid-js/mermaid/pull/3777](https://togithub.com/mermaid-js/mermaid/pull/3777)
- chore: Housekeeping by
[@&#8203;sidharthv96](https://togithub.com/sidharthv96) in
[https://github.com/mermaid-js/mermaid/pull/3783](https://togithub.com/mermaid-js/mermaid/pull/3783)
- Pnpm issue reproduction by
[@&#8203;sidharthv96](https://togithub.com/sidharthv96) in
[https://github.com/mermaid-js/mermaid/pull/3784](https://togithub.com/mermaid-js/mermaid/pull/3784)
- fix(deps): update all non-major dependencies (patch) by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/mermaid-js/mermaid/pull/3790](https://togithub.com/mermaid-js/mermaid/pull/3790)
- chore: clean up code in mermaidAPI render() and write specs/tests by
[@&#8203;weedySeaDragon](https://togithub.com/weedySeaDragon) in
[https://github.com/mermaid-js/mermaid/pull/3684](https://togithub.com/mermaid-js/mermaid/pull/3684)
- chore(deps): update all non-major dependencies (minor) by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/mermaid-js/mermaid/pull/3791](https://togithub.com/mermaid-js/mermaid/pull/3791)
- fix(deps): update dependency rollup to v3 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/mermaid-js/mermaid/pull/3674](https://togithub.com/mermaid-js/mermaid/pull/3674)
- Add GHA that will check links + Fix broken links by
[@&#8203;spier](https://togithub.com/spier) in
[https://github.com/mermaid-js/mermaid/pull/3765](https://togithub.com/mermaid-js/mermaid/pull/3765)
- chore: Merge master to develop by
[@&#8203;sidharthv96](https://togithub.com/sidharthv96) in
[https://github.com/mermaid-js/mermaid/pull/3780](https://togithub.com/mermaid-js/mermaid/pull/3780)
- bug: change shiki getHighlighter import by
[@&#8203;weedySeaDragon](https://togithub.com/weedySeaDragon) in
[https://github.com/mermaid-js/mermaid/pull/3804](https://togithub.com/mermaid-js/mermaid/pull/3804)
- Fix
[#&#8203;3799](https://togithub.com/mermaid-js/mermaid/issues/3799):
Remove `type` from package.json by
[@&#8203;sidharthv96](https://togithub.com/sidharthv96) in
[https://github.com/mermaid-js/mermaid/pull/3802](https://togithub.com/mermaid-js/mermaid/pull/3802)
- CI: disable pinning dependencies by
[@&#8203;aloisklink](https://togithub.com/aloisklink) in
[https://github.com/mermaid-js/mermaid/pull/3735](https://togithub.com/mermaid-js/mermaid/pull/3735)
- bug: State diagram fix classes type by
[@&#8203;weedySeaDragon](https://togithub.com/weedySeaDragon) in
[https://github.com/mermaid-js/mermaid/pull/3798](https://togithub.com/mermaid-js/mermaid/pull/3798)
- Remove extra arrow and adjust cross position by
[@&#8203;ishuen](https://togithub.com/ishuen) in
[https://github.com/mermaid-js/mermaid/pull/3641](https://togithub.com/mermaid-js/mermaid/pull/3641)
- comments in states are skipped now by
[@&#8203;avijit1258](https://togithub.com/avijit1258) in
[https://github.com/mermaid-js/mermaid/pull/3762](https://togithub.com/mermaid-js/mermaid/pull/3762)
- feat: Redirect old documentation links. by
[@&#8203;sidharthv96](https://togithub.com/sidharthv96) in
[https://github.com/mermaid-js/mermaid/pull/3797](https://togithub.com/mermaid-js/mermaid/pull/3797)
- Mindmap integration docs by
[@&#8203;sidharthv96](https://togithub.com/sidharthv96) in
[https://github.com/mermaid-js/mermaid/pull/3810](https://togithub.com/mermaid-js/mermaid/pull/3810)
- Use `github-dark` to highlight fence blocks in vitepress docs by
[@&#8203;aloisklink](https://togithub.com/aloisklink) in
[https://github.com/mermaid-js/mermaid/pull/3807](https://togithub.com/mermaid-js/mermaid/pull/3807)
- chore(deps): update lycheeverse/lychee-action action to v1.5.4 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/mermaid-js/mermaid/pull/3827](https://togithub.com/mermaid-js/mermaid/pull/3827)
- chore(deps): update pnpm to v7.17.0 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/mermaid-js/mermaid/pull/3828](https://togithub.com/mermaid-js/mermaid/pull/3828)
- feat: Title support via front matter for ER, state, class, git, and
graph diagrams by [@&#8203;MasonM](https://togithub.com/MasonM) in
[https://github.com/mermaid-js/mermaid/pull/3706](https://togithub.com/mermaid-js/mermaid/pull/3706)
- Replace `dagre`/`dagre-d3` with `dagre-d3-es` by
[@&#8203;aloisklink](https://togithub.com/aloisklink) in
[https://github.com/mermaid-js/mermaid/pull/3809](https://togithub.com/mermaid-js/mermaid/pull/3809)
- Add package visualizations by
[@&#8203;sidharthv96](https://togithub.com/sidharthv96) in
[https://github.com/mermaid-js/mermaid/pull/3823](https://togithub.com/mermaid-js/mermaid/pull/3823)
- [#&#8203;3882](https://togithub.com/mermaid-js/mermaid/issues/3882)
fix for issues with mindmaps with only a single node by
[@&#8203;knsv](https://togithub.com/knsv) in
[https://github.com/mermaid-js/mermaid/pull/3833](https://togithub.com/mermaid-js/mermaid/pull/3833)
- [#&#8203;3778](https://togithub.com/mermaid-js/mermaid/issues/3778)
Adding a hexgon shape by [@&#8203;knsv](https://togithub.com/knsv) in
[https://github.com/mermaid-js/mermaid/pull/3834](https://togithub.com/mermaid-js/mermaid/pull/3834)
- Fix for
[#&#8203;3835](https://togithub.com/mermaid-js/mermaid/issues/3835),
makes it possible to style path elements by
[@&#8203;knsv](https://togithub.com/knsv) in
[https://github.com/mermaid-js/mermaid/pull/3836](https://togithub.com/mermaid-js/mermaid/pull/3836)
- [#&#8203;3831](https://togithub.com/mermaid-js/mermaid/issues/3831)
Re-enabling themes for er diagrams by
[@&#8203;knsv](https://togithub.com/knsv) in
[https://github.com/mermaid-js/mermaid/pull/3837](https://togithub.com/mermaid-js/mermaid/pull/3837)
- (chore) remove console stmt in pieDetector by
[@&#8203;weedySeaDragon](https://togithub.com/weedySeaDragon) in
[https://github.com/mermaid-js/mermaid/pull/3840](https://togithub.com/mermaid-js/mermaid/pull/3840)
- Revert "Added pie" by
[@&#8203;pbrolin47](https://togithub.com/pbrolin47) in
[https://github.com/mermaid-js/mermaid/pull/3842](https://togithub.com/mermaid-js/mermaid/pull/3842)
- Fix typos by [@&#8203;endolith](https://togithub.com/endolith) in
[https://github.com/mermaid-js/mermaid/pull/3820](https://togithub.com/mermaid-js/mermaid/pull/3820)
- (feat) state classDef documentation by
[@&#8203;weedySeaDragon](https://togithub.com/weedySeaDragon) in
[https://github.com/mermaid-js/mermaid/pull/3841](https://togithub.com/mermaid-js/mermaid/pull/3841)
- Integrations added - Visual Studio Code \[Polyglot Interactive
Notebooks] by [@&#8203;dfinke](https://togithub.com/dfinke) in
[https://github.com/mermaid-js/mermaid/pull/3821](https://togithub.com/mermaid-js/mermaid/pull/3821)
- Reduce mermaid size by 31% by
[@&#8203;sidharthv96](https://togithub.com/sidharthv96) in
[https://github.com/mermaid-js/mermaid/pull/3825](https://togithub.com/mermaid-js/mermaid/pull/3825)
- fix: LintStaged by
[@&#8203;sidharthv96](https://togithub.com/sidharthv96) in
[https://github.com/mermaid-js/mermaid/pull/3844](https://togithub.com/mermaid-js/mermaid/pull/3844)
- Add official vim plugin to list in integrations by
[@&#8203;craigmac](https://togithub.com/craigmac) in
[https://github.com/mermaid-js/mermaid/pull/3847](https://togithub.com/mermaid-js/mermaid/pull/3847)
- chore(deps): remove dependency on `graphlib` by
[@&#8203;aloisklink](https://togithub.com/aloisklink) in
[https://github.com/mermaid-js/mermaid/pull/3861](https://togithub.com/mermaid-js/mermaid/pull/3861)
- chore(deps): update pnpm to v7.17.1 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/mermaid-js/mermaid/pull/3862](https://togithub.com/mermaid-js/mermaid/pull/3862)
- Make gitgraph snapshots consistent in E2E tests by
[@&#8203;aloisklink](https://togithub.com/aloisklink) in
[https://github.com/mermaid-js/mermaid/pull/3860](https://togithub.com/mermaid-js/mermaid/pull/3860)
- Use stylis to prepend idSelector by
[@&#8203;DanInProgress](https://togithub.com/DanInProgress) in
[https://github.com/mermaid-js/mermaid/pull/3829](https://togithub.com/mermaid-js/mermaid/pull/3829)
- Use current mermaid version in docs. by
[@&#8203;sidharthv96](https://togithub.com/sidharthv96) in
[https://github.com/mermaid-js/mermaid/pull/3846](https://togithub.com/mermaid-js/mermaid/pull/3846)
- Add support for [@&#8203;include](https://togithub.com/include) in
docs by [@&#8203;sidharthv96](https://togithub.com/sidharthv96) in
[https://github.com/mermaid-js/mermaid/pull/3863](https://togithub.com/mermaid-js/mermaid/pull/3863)
- Housekeeping with eslint-unicorn by
[@&#8203;sidharthv96](https://togithub.com/sidharthv96) in
[https://github.com/mermaid-js/mermaid/pull/3845](https://togithub.com/mermaid-js/mermaid/pull/3845)
- chore: delete functions not used in diagrams/c4 code (dead code) by
[@&#8203;weedySeaDragon](https://togithub.com/weedySeaDragon) in
[https://github.com/mermaid-js/mermaid/pull/3871](https://togithub.com/mermaid-js/mermaid/pull/3871)
- Switch back to jsdelivr by
[@&#8203;sidharthv96](https://togithub.com/sidharthv96) in
[https://github.com/mermaid-js/mermaid/pull/3873](https://togithub.com/mermaid-js/mermaid/pull/3873)
- 3882 edge labels by [@&#8203;knsv](https://togithub.com/knsv) in
[https://github.com/mermaid-js/mermaid/pull/3883](https://togithub.com/mermaid-js/mermaid/pull/3883)
- Small fix for issue
[#&#8203;3881](https://togithub.com/mermaid-js/mermaid/issues/3881) by
[@&#8203;knsv](https://togithub.com/knsv) in
[https://github.com/mermaid-js/mermaid/pull/3884](https://togithub.com/mermaid-js/mermaid/pull/3884)
- Defects/issue 3878 by [@&#8203;MrCoder](https://togithub.com/MrCoder)
in
[https://github.com/mermaid-js/mermaid/pull/3880](https://togithub.com/mermaid-js/mermaid/pull/3880)
- chore(docs): Auto build docs by
[@&#8203;sidharthv96](https://togithub.com/sidharthv96) in
[https://github.com/mermaid-js/mermaid/pull/3547](https://togithub.com/mermaid-js/mermaid/pull/3547)
- docs: refactor Theming doc by
[@&#8203;huynhicode](https://togithub.com/huynhicode) in
[https://github.com/mermaid-js/mermaid/pull/3889](https://togithub.com/mermaid-js/mermaid/pull/3889)
- Feat: Add aria-describedby, aria-roledescription by
[@&#8203;weedySeaDragon](https://togithub.com/weedySeaDragon) in
[https://github.com/mermaid-js/mermaid/pull/3808](https://togithub.com/mermaid-js/mermaid/pull/3808)
- Release/9.3.0 by
[@&#8203;sidharthv96](https://togithub.com/sidharthv96) in
[https://github.com/mermaid-js/mermaid/pull/3911](https://togithub.com/mermaid-js/mermaid/pull/3911)

#### New Contributors

- [@&#8203;revolter](https://togithub.com/revolter) made their first
contribution in
[https://github.com/mermaid-js/mermaid/pull/3657](https://togithub.com/mermaid-js/mermaid/pull/3657)
- [@&#8203;Some-Dood](https://togithub.com/Some-Dood) made their first
contribution in
[https://github.com/mermaid-js/mermaid/pull/3643](https://togithub.com/mermaid-js/mermaid/pull/3643)
- [@&#8203;danangtomo](https://togithub.com/danangtomo) made their first
contribution in
[https://github.com/mermaid-js/mermaid/pull/3679](https://togithub.com/mermaid-js/mermaid/pull/3679)
- [@&#8203;DKurilo](https://togithub.com/DKurilo) made their first
contribution in
[https://github.com/mermaid-js/mermaid/pull/3690](https://togithub.com/mermaid-js/mermaid/pull/3690)
- [@&#8203;devcer](https://togithub.com/devcer) made their first
contribution in
[https://github.com/mermaid-js/mermaid/pull/3604](https://togithub.com/mermaid-js/mermaid/pull/3604)
- [@&#8203;isinek](https://togithub.com/isinek) made their first
contribution in
[https://github.com/mermaid-js/mermaid/pull/3688](https://togithub.com/mermaid-js/mermaid/pull/3688)
- [@&#8203;jeroenekkelkamp](https://togithub.com/jeroenekkelkamp) made
their first contribution in
[https://github.com/mermaid-js/mermaid/pull/3698](https://togithub.com/mermaid-js/mermaid/pull/3698)
- [@&#8203;imgss](https://togithub.com/imgss) made their first
contribution in
[https://github.com/mermaid-js/mermaid/pull/3707](https://togithub.com/mermaid-js/mermaid/pull/3707)
- [@&#8203;jasmaa](https://togithub.com/jasmaa) made their first
contribution in
[https://github.com/mermaid-js/mermaid/pull/3609](https://togithub.com/mermaid-js/mermaid/pull/3609)
- [@&#8203;uttk](https://togithub.com/uttk) made their first
contribution in
[https://github.com/mermaid-js/mermaid/pull/3652](https://togithub.com/mermaid-js/mermaid/pull/3652)
- [@&#8203;CalebUsadi](https://togithub.com/CalebUsadi) made their first
contribution in
[https://github.com/mermaid-js/mermaid/pull/3719](https://togithub.com/mermaid-js/mermaid/pull/3719)
- [@&#8203;marcjansen](https://togithub.com/marcjansen) made their first
contribution in
[https://github.com/mermaid-js/mermaid/pull/3721](https://togithub.com/mermaid-js/mermaid/pull/3721)
- [@&#8203;DarkNami](https://togithub.com/DarkNami) made their first
contribution in
[https://github.com/mermaid-js/mermaid/pull/3729](https://togithub.com/mermaid-js/mermaid/pull/3729)
- [@&#8203;6footGeek](https://togithub.com/6footGeek) made their first
contribution in
[https://github.com/mermaid-js/mermaid/pull/3741](https://togithub.com/mermaid-js/mermaid/pull/3741)
- [@&#8203;hugovk](https://togithub.com/hugovk) made their first
contribution in
[https://github.com/mermaid-js/mermaid/pull/3752](https://togithub.com/mermaid-js/mermaid/pull/3752)
- [@&#8203;raptor0929](https://togithub.com/raptor0929) made their first
contribution in
[https://github.com/mermaid-js/mermaid/pull/3738](https://togithub.com/mermaid-js/mermaid/pull/3738)
- [@&#8203;spier](https://togithub.com/spier) made their first
contribution in
[https://github.com/mermaid-js/mermaid/pull/3760](https://togithub.com/mermaid-js/mermaid/pull/3760)
- [@&#8203;ishuen](https://togithub.com/ishuen) made their first
contribution in
[https://github.com/mermaid-js/mermaid/pull/3641](https://togithub.com/mermaid-js/mermaid/pull/3641)
- [@&#8203;avijit1258](https://togithub.com/avijit1258) made their first
contribution in
[https://github.com/mermaid-js/mermaid/pull/3762](https://togithub.com/mermaid-js/mermaid/pull/3762)
- [@&#8203;MasonM](https://togithub.com/MasonM) made their first
contribution in
[https://github.com/mermaid-js/mermaid/pull/3706](https://togithub.com/mermaid-js/mermaid/pull/3706)
- [@&#8203;endolith](https://togithub.com/endolith) made their first
contribution in
[https://github.com/mermaid-js/mermaid/pull/3820](https://togithub.com/mermaid-js/mermaid/pull/3820)
- [@&#8203;dfinke](https://togithub.com/dfinke) made their first
contribution in
[https://github.com/mermaid-js/mermaid/pull/3821](https://togithub.com/mermaid-js/mermaid/pull/3821)
- [@&#8203;craigmac](https://togithub.com/craigmac) made their first
contribution in
[https://github.com/mermaid-js/mermaid/pull/3847](https://togithub.com/mermaid-js/mermaid/pull/3847)
- [@&#8203;DanInProgress](https://togithub.com/DanInProgress) made their
first contribution in
[https://github.com/mermaid-js/mermaid/pull/3829](https://togithub.com/mermaid-js/mermaid/pull/3829)
- [@&#8203;MrCoder](https://togithub.com/MrCoder) made their first
contribution in
[https://github.com/mermaid-js/mermaid/pull/3880](https://togithub.com/mermaid-js/mermaid/pull/3880)
- [@&#8203;huynhicode](https://togithub.com/huynhicode) made their first
contribution in
[https://github.com/mermaid-js/mermaid/pull/3889](https://togithub.com/mermaid-js/mermaid/pull/3889)

**Full Changelog**:
mermaid-js/mermaid@v9.2.2...v9.3.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/BirthdayResearch/contented).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC41NC4yIiwidXBkYXRlZEluVmVyIjoiMzQuNjIuMSJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@MrCoder MrCoder deleted the defects/issue-3878 branch January 2, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Diagrams disappear from the doc page when switch on/off dark mode
2 participants